From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amirouche Boubekki Subject: Re: [PATCH] gnu: link-grammar: New module. Date: Fri, 04 Nov 2016 18:13:28 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e013c67da26dd5c05407da2e9 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2izm-0001v9-GR for guix-devel@gnu.org; Fri, 04 Nov 2016 14:13:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2izl-0006ky-F9 for guix-devel@gnu.org; Fri, 04 Nov 2016 14:13:42 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:35511) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2izl-0006gp-80 for guix-devel@gnu.org; Fri, 04 Nov 2016 14:13:41 -0400 Received: by mail-wm0-x241.google.com with SMTP id 68so5080826wmz.2 for ; Fri, 04 Nov 2016 11:13:40 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Amir P , guix-devel@gnu.org --089e013c67da26dd5c05407da2e9 Content-Type: text/plain; charset=UTF-8 Thx for the review and explanation. I am not in a hurry, I will wait for the 5.3.12 release. On Mon, Oct 24, 2016 at 7:03 PM Amir P wrote: > On Sun, 23 Oct 2016 17:20:11 -0400 Leo Famulari wrote: > > If sqlite and zlib are only used when building, but not when running > > link-grammar, then they should be native-inputs. > > > > Otherwise, we will need to figure out how to make link-grammar retain > > references to these libraries. > > The link-grammar library doesn't use the zlib library directly or > indirectly. > What happens is that zlib.h is needed for the compilation of its > sat-solver code > because it is included in a header file of the minisat library which is > indirectly > included by the sat-solver code. So zlib (actually zlib.h) is only used > when building. > > However, if the sqlite library+headers exist when using "configure", > HAVE_SQLITE will get defined, which will bring in code that can use sqlite > (sqlite3_open etc. are referenced in the result link-grammar library). > As this code is currently not fully functional, a solution may be to > "configure" > link-grammar without the presence of the sqlite library+headers. > A better solution may be to add a link-grammar "configure" option like > "--enable-sqlite". > If you think it is indeed better, I will open an issue there for adding it > - to be > included in the next version - 5.3.12. > In any case, 5.3.12 is needed to overcome additional problems in 5.3.11 > (some > of them are already fixed in the repository, and for some others > pull-requests are > still pending). > --089e013c67da26dd5c05407da2e9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thx for the review and explanation.

I am= not in a hurry, I will wait for the 5.3.12 release.

On Mon, Oct 24, 2016 at 7:03 PM Amir P &= lt;amirpli@gmail.com> wrote:
=
On=C2=A0Sun, 23 = Oct 2016 17:20:11 -0400=C2=A0Leo Famulari wrote:
> I= f sqlite and zlib are only used when building, but not when running<= /div>
> link-grammar, then they should be native-inputs.=
>
> Otherwise, we will need to fig= ure out how to make link-grammar retain
> references= to these libraries.
The link-grammar library doesn't use the zlib library d= irectly or indirectly.
What hap= pens is that zlib.h is needed for the compilation of its sat-solver code
because it is included in a heade= r file of the minisat library which is indirectly
included by the sat-solver code. So zlib (actually zlib.= h) is only used when building.
=
Howeve= r, if the sqlite library+headers exist when using "configure",
HAVE_SQLITE will get defined, whi= ch will bring in code that can use sqlite
(sqlite3_open etc. are referenced in the result link-grammar lib= rary).
As this code is currentl= y not fully functional, a solution may be to "configure"
link-grammar without the presence of th= e=C2=A0sqlite library+headers.
= A better solution may be to add a link-grammar "configure" option= like "--enable-sqlite".
If you think it is indeed better, I will open an issue there for adding= it - to be
included in the nex= t version - 5.3.12.
In any case= , 5.3.12 is needed to overcome additional problems in 5.3.11 (some=C2=A0
of them are already fixed in the = repository, and for some others pull-requests are
still pending).
--089e013c67da26dd5c05407da2e9--