From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amirouche Boubekki Subject: Re: [PATCH] Add scheme-bytestructures Date: Wed, 19 Oct 2016 07:18:37 +0000 Message-ID: References: <87fuo4hz3c.fsf@openmailbox.org> <8760p0gcer.fsf@gnu.org> <877f95ivf9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11443a00d50e5b053f329e78 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwl9I-0002F7-K0 for guix-devel@gnu.org; Wed, 19 Oct 2016 03:18:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwl9H-00009r-AS for guix-devel@gnu.org; Wed, 19 Oct 2016 03:18:52 -0400 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:36619) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bwl9G-00007U-RW for guix-devel@gnu.org; Wed, 19 Oct 2016 03:18:51 -0400 Received: by mail-wm0-x233.google.com with SMTP id f193so40559054wmg.1 for ; Wed, 19 Oct 2016 00:18:50 -0700 (PDT) In-Reply-To: <877f95ivf9.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Kebreau , guix-devel --001a11443a00d50e5b053f329e78 Content-Type: multipart/alternative; boundary=001a11443a00d50e4f053f329e76 --001a11443a00d50e4f053f329e76 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Updated the patch. On Tue, Oct 18, 2016 at 4:28 PM Ludovic Court=C3=A8s wrote: > Amirouche Boubekki skribis: > > > On Mon, Oct 10, 2016 at 10:46 PM Ludovic Court=C3=A8s wr= ote: > > > [...] > >> Please let=E2=80=99s not list all the files. :-) Could it instead us= e > >> something like (find-files "bytestructures" "\\.scm$")? > >> > > > > The above is a subset of all files. Do you prefer to use `find-files` a= nd > > exclude some files? > > Whichever is the most concise and most maintainable approach (I suspect > it=E2=80=99s =E2=80=98find-files=E2=80=99 + exclude specific files.) > > Ludo=E2=80=99. > find-files does the right thing, there is no need to filter what it returns= . --001a11443a00d50e4f053f329e76 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Updated the patch.

On Tue, Oct 18, 2016 at 4:28 PM Ludov= ic Court=C3=A8s <ludo@gnu.org> wr= ote:
Amirouche Boubekki <amirouche.boubekki@gmail.com> skribis:

> On Mon, Oct 10, 2016 at 10:46 PM Ludovic Court=C3=A8s <ludo@gnu.org&= gt; wrote:
>

[...]
=C2=A0
>> Please let=E2=80=99s not list all the files.=C2=A0 :-)=C2=A0 Could= it instead use
>> something like (find-files "bytestructures" "\\.scm= $")?
>>
>
> The above is a subset of all files. Do you prefer to use `find-files` = and
> exclude some files?

Whichever is the most concise and most maintainable approach (I suspect
it=E2=80=99s =E2=80=98find-files=E2=80=99 + exclude specific files.)

Ludo=E2=80=99.

find-files does= the right thing, there is no need to filter what it returns.
=

=C2=A0
--001a11443a00d50e4f053f329e76-- --001a11443a00d50e5b053f329e78 Content-Type: text/x-patch; charset=US-ASCII; name="0001-gnu-Add-guile-bytestructures.patch" Content-Disposition: attachment; filename="0001-gnu-Add-guile-bytestructures.patch" Content-Transfer-Encoding: base64 Content-ID: <157dbce50d0b323a2d21> X-Attachment-Id: 157dbce50d0b323a2d21 RnJvbSBlYTg4YmY0YjUzYTYzYmEwZDU0ZjcxNjIyZDA1NWMzMmNkN2UzNDZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbWlyb3VjaGUgPGFtaXJvdWNoZUBoeXBlcm1vdmUubmV0PgpE YXRlOiBTdW4sIDkgT2N0IDIwMTYgMTI6MzE6MjAgKzAyMDAKU3ViamVjdDogW1BBVENIXSBnbnU6 IEFkZCBndWlsZS1ieXRlc3RydWN0dXJlcwoKKiBnbnUvcGFja2FnZXMvZ3VpbGUuc2NtIChndWls ZS1ieXRlc3RydWN0dXJlcyk6IE5ldyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvZ3VpbGUu c2NtIHwgNzggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKIDEgZmlsZSBjaGFuZ2VkLCA3OCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3Bh Y2thZ2VzL2d1aWxlLnNjbSBiL2dudS9wYWNrYWdlcy9ndWlsZS5zY20KaW5kZXggNDMwNzFlNi4u YTAzY2I0NCAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2d1aWxlLnNjbQorKysgYi9nbnUvcGFj a2FnZXMvZ3VpbGUuc2NtCkBAIC0xMjY3LDQgKzEyNjcsODIgQEAgaXMgbm8gc3VwcG9ydCBmb3Ig cGFyc2luZyBibG9jayBhbmQgaW5saW5lIGxldmVsIEhUTUwuIikKIChkZWZpbmUtcHVibGljIGd1 aWxlMi4yLWNvbW1vbm1hcmsKICAgKHBhY2thZ2UtZm9yLWd1aWxlLTIuMiBndWlsZS1jb21tb25t YXJrKSkKIAorKGRlZmluZS1wdWJsaWMgZ3VpbGUtYnl0ZXN0cnVjdHVyZXMKKyAgKHBhY2thZ2UK KyAgICAobmFtZSAiZ3VpbGUtYnl0ZXN0cnVjdHVyZXMiKQorICAgICh2ZXJzaW9uICIyMDE2MDcy Ni41MzEyN2Y2IikKKyAgICAoc291cmNlIChvcmlnaW4KKyAgICAgICAgICAgICAgKG1ldGhvZCBn aXQtZmV0Y2gpCisgICAgICAgICAgICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAg ICAgICAgICAgKHVybCAiaHR0cHM6Ly9naXRodWIuY29tL1RheWxhblVCL3NjaGVtZS1ieXRlc3Ry dWN0dXJlcyIpCisgICAgICAgICAgICAgICAgICAgIChjb21taXQgIjUzMTI3ZjYwOGNhZjY0YjM0 ZmE0MWMzODliMjc0M2I1NDZmYmU5ZGEiKSkpCisgICAgICAgICAgICAgIChmaWxlLW5hbWUgKHN0 cmluZy1hcHBlbmQgbmFtZSAiLSIgdmVyc2lvbiAiLWNoZWNrb3V0IikpCisgICAgICAgICAgICAg IChzaGEyNTYKKyAgICAgICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICAgICAiMGw0bngx dnA5ZmtyZ3Jnd2ppeWNqN254NndmamZkMzlycWFtdjRwbXE3aXNzaThtcnl3cSIpKSkpCisgICAg KGJ1aWxkLXN5c3RlbSB0cml2aWFsLWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAg IGAoIzptb2R1bGVzICgoZ3VpeCBidWlsZCB1dGlscykpCisgICAgICAgIzpidWlsZGVyCisgICAg ICAgKGJlZ2luCisgICAgICAgICAodXNlLW1vZHVsZXMgKGd1aXggYnVpbGQgdXRpbHMpCisgICAg ICAgICAgICAgICAgICAgICAgKGljZS05IG1hdGNoKQorICAgICAgICAgICAgICAgICAgICAgIChp Y2UtOSBwb3BlbikKKyAgICAgICAgICAgICAgICAgICAgICAoaWNlLTkgcmRlbGltKSkKKworICAg ICAgICAgKGxldCogKChvdXQgKGFzc29jLXJlZiAlb3V0cHV0cyAib3V0IikpCisgICAgICAgICAg ICAgICAgKGd1aWxlIChhc3NvYy1yZWYgJWJ1aWxkLWlucHV0cyAiZ3VpbGUiKSkKKyAgICAgICAg ICAgICAgICAoZWZmZWN0aXZlIChyZWFkLWxpbmUKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAob3Blbi1waXBlKiBPUEVOX1JFQUQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoc3RyaW5nLWFwcGVuZCBndWlsZSAiL2Jpbi9ndWlsZSIpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIi1jIiAiKGRpc3BsYXkgKGVmZmVjdGl2ZS12ZXJz aW9uKSkiKSkpCisgICAgICAgICAgICAgICAgKG1vZHVsZS1kaXIgKHN0cmluZy1hcHBlbmQgb3V0 ICIvc2hhcmUvZ3VpbGUvc2l0ZS8iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZWZmZWN0aXZlKSkKKyAgICAgICAgICAgICAgICAoc291cmNlIChhc3NvYy1yZWYg JWJ1aWxkLWlucHV0cyAic291cmNlIikpCisgICAgICAgICAgICAgICAgKGRvYyAoc3RyaW5nLWFw cGVuZCBvdXQgIi9zaGFyZS9kb2Mvc2NoZW1lLWJ5dGVzdHJ1Y3R1cmVzIikpCisgICAgICAgICAg ICAgICAgKHNjbS1maWxlcyAoZmluZC1maWxlcyAiYnl0ZXN0cnVjdHVyZXMiICJcXC5zY20kIikp CisgICAgICAgICAgICAgICAgKGd1aWxkIChzdHJpbmctYXBwZW5kIChhc3NvYy1yZWYgJWJ1aWxk LWlucHV0cyAiZ3VpbGUiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi L2Jpbi9ndWlsZCIpKSkKKyAgICAgICAgICAgOzsgTWFrZSBpbnN0YWxsYXRpb24gZGlyZWN0b3Jp ZXMuCisgICAgICAgICAgIChta2Rpci1wIChzdHJpbmctYXBwZW5kIG1vZHVsZS1kaXIgIi9ieXRl c3RydWN0dXJlcy9ndWlsZSIpKQorICAgICAgICAgICAobWtkaXItcCAoc3RyaW5nLWFwcGVuZCBt b2R1bGUtZGlyICIvYnl0ZXN0cnVjdHVyZXMvcjYiKSkKKyAgICAgICAgICAgKG1rZGlyLXAgKHN0 cmluZy1hcHBlbmQgbW9kdWxlLWRpciAiL2J5dGVzdHJ1Y3R1cmVzL2JvZHkiKSkKKyAgICAgICAg ICAgKG1rZGlyLXAgZG9jKQorCisgICAgICAgICAgIDs7IENvbXBpbGUgLnNjbSBmaWxlcyBhbmQg aW5zdGFsbC4KKyAgICAgICAgICAgKGNoZGlyIHNvdXJjZSkKKyAgICAgICAgICAgKHNldGVudiAi R1VJTEVfQVVUT19DT01QSUxFIiAiMCIpCisgICAgICAgICAgIChmb3ItZWFjaCAobGFtYmRhIChm aWxlKQorICAgICAgICAgICAgICAgICAgICAgICAobGV0KiAoKGRlc3QtZmlsZSAoc3RyaW5nLWFw cGVuZCBtb2R1bGUtZGlyICIvIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBmaWxlKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChnby1maWxlIChzdHJpbmctYXBwZW5kIG1vZHVsZS1kaXIgIi8iCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3Vic3RyaW5nIGZpbGUgMAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoc3RyaW5nLXJpbmRleCBmaWxlICNcLikpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiLmdvIikpKQorICAgICAgICAgICAgICAg ICAgICAgICAgIDs7IEluc3RhbGwgc291cmNlIG1vZHVsZS4KKyAgICAgICAgICAgICAgICAgICAg ICAgICAoY29weS1maWxlIGZpbGUgZGVzdC1maWxlKQorICAgICAgICAgICAgICAgICAgICAgICAg IDs7IEluc3RhbGwgY29tcGlsZWQgbW9kdWxlLgorICAgICAgICAgICAgICAgICAgICAgICAgICh1 bmxlc3MgKHplcm8/IChzeXN0ZW0qIGd1aWxkICJjb21waWxlIgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICItTCIgc291cmNlCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIi1vIiBnby1maWxlCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsZSkpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAoZXJyb3IgKGZvcm1hdCAjZiAiRmFpbGVkIHRvIGNvbXBpbGUg fnMgdG8gfnMhIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmls ZSBnby1maWxlKSkpKSkKKyAgICAgICAgICAgICAgICAgICAgIHNjbS1maWxlcykKKworICAgICAg ICAgICA7OyBBbHNvIGNvcHkgb3ZlciB0aGUgUkVBRE1FLgorICAgICAgICAgICAoaW5zdGFsbC1m aWxlICJSRUFETUUubWQiIGRvYykKKyAgICAgICAgICAgI3QpKSkpCisgICAgKGlucHV0cworICAg ICBgKCgiZ3VpbGUiICxndWlsZS0yLjApKSkKKyAgICAoaG9tZS1wYWdlICJodHRwczovL2dpdGh1 Yi5jb20vVGF5bGFuVUIvc2NoZW1lLWJ5dGVzdHJ1Y3R1cmVzIikKKyAgICAoc3lub3BzaXMgIlN0 cnVjdHVyZWQgYWNjZXNzIHRvIGJ5dGV2ZWN0b3IgY29udGVudHMgZm9yIEd1aWxlIikKKyAgICAo ZGVzY3JpcHRpb24KKyAgICAgIkd1aWxlIGJ5dGVzdHJ1Y3R1cmVzIG9mZmVycyBhIHN5c3RlbSBp bWl0YXRpbmcgdGhlIHR5cGUgc3lzdGVtCitvZiB0aGUgQyBwcm9ncmFtbWluZyBsYW5ndWFnZSwg dG8gYmUgdXNlZCBvbiBieXRldmVjdG9ycy4gIEMncyB0eXBlCitzeXN0ZW0gd29ya3Mgb24gcmF3 IG1lbW9yeSwgYW5kIEd1aWxlIHdvcmtzIG9uIGJ5dGV2ZWN0b3JzIHdoaWNoIGFyZQorYW4gYWJz dHJhY3Rpb24gb3ZlciByYXcgbWVtb3J5LiAgSXQncyBhbHNvIG1vcmUgcG93ZXJmdWwgdGhhbiB0 aGUgQwordHlwZSBzeXN0ZW0sIGVsZXZhdGluZyB0eXBlcyB0byBmaXJzdC1jbGFzcyBzdGF0dXMu IikKKyAgICAobGljZW5zZSBncGwzKykpKQorCiA7OzsgZ3VpbGUuc2NtIGVuZHMgaGVyZQotLSAK Mi4xMC4wCgo= --001a11443a00d50e5b053f329e78--