From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Craven <david@craven.ch>
Subject: Re: [PATCH 08/24] gnu: xorg: Add lndir.
Date: Wed, 17 Aug 2016 10:35:38 +0200
Message-ID: <CAL1_imnjJM_+=26_GT49VLC0E-gQLGYxj=+BsPNG52U31Ji-oQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40819)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bZwKA-0004Wo-7C
	for guix-devel@gnu.org; Wed, 17 Aug 2016 04:35:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bZwK6-0006c9-1H
	for guix-devel@gnu.org; Wed, 17 Aug 2016 04:35:45 -0400
Received: from mail-yw0-x244.google.com ([2607:f8b0:4002:c05::244]:33747)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bZwK4-0006bU-Ln
	for guix-devel@gnu.org; Wed, 17 Aug 2016 04:35:41 -0400
Received: by mail-yw0-x244.google.com with SMTP id z8so4956247ywa.0
	for <guix-devel@gnu.org>; Wed, 17 Aug 2016 01:35:39 -0700 (PDT)
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel <guix-devel@gnu.org>, Alex Kost <alezost@gmail.com>

> The patch looks good to me, except the indentation of this
>
> (string-append ...).  I usually write 'source' fields like this:
>
>    (source (origin
>              (method url-fetch)
>              (uri (string-append "mirror://xorg/individual/util/lndir-"
>                                  version ".tar.bz2"))
>              (sha256
>               (base32
>                "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
>
> But this is not a big deal, of course :-)

I prefer
(uri (string-append
        "mirror://xorg/individual/util/"
        "lndir-" version ".tar.bz2"))

But in this case I thought that keeping consistent with how it was
done in the xorg.scm file was more important than my preference. What
do you think?