* [PATCH 08/24] gnu: xorg: Add lndir.
2016-08-16 18:39 [PATCH 01/24] gnu: qt: Add qtquickcontrols David Craven
@ 2016-08-16 18:39 ` David Craven
2016-08-16 19:53 ` Alex Kost
0 siblings, 1 reply; 4+ messages in thread
From: David Craven @ 2016-08-16 18:39 UTC (permalink / raw)
To: guix-devel; +Cc: David Craven
* gnu/packages/xorg.scm (lndir): New variable.
---
gnu/packages/xorg.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index b24e437..1e7da68 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -133,6 +133,31 @@ projects. Software developers are encouraged to migrate software to the GNU
autotools system.")
(license license:x11)))
+(define-public lndir
+ (package
+ (name "lndir")
+ (version "1.0.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "mirror://xorg/individual/util/lndir-"
+ version
+ ".tar.bz2"))
+ (sha256
+ (base32
+ "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
+ `(("xproto" ,xproto)))
+ (home-page "http://www.x.org")
+ (synopsis "Symlink directory into tree")
+ (description "Create a shadow directory of symbolic links to another
+directory tree.")
+ (license license:x11)))
+
(define-public bdftopcf
(package
(name "bdftopcf")
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 08/24] gnu: xorg: Add lndir.
2016-08-16 18:39 ` [PATCH 08/24] gnu: xorg: Add lndir David Craven
@ 2016-08-16 19:53 ` Alex Kost
0 siblings, 0 replies; 4+ messages in thread
From: Alex Kost @ 2016-08-16 19:53 UTC (permalink / raw)
To: David Craven; +Cc: guix-devel
David Craven (2016-08-16 21:39 +0300) wrote:
> * gnu/packages/xorg.scm (lndir): New variable.
Nice program, I didn't know about it, thanks!
> ---
> gnu/packages/xorg.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
>
> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
> index b24e437..1e7da68 100644
> --- a/gnu/packages/xorg.scm
> +++ b/gnu/packages/xorg.scm
> @@ -133,6 +133,31 @@ projects. Software developers are encouraged to migrate software to the GNU
> autotools system.")
> (license license:x11)))
>
> +(define-public lndir
> + (package
> + (name "lndir")
> + (version "1.0.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://xorg/individual/util/lndir-"
> + version
> + ".tar.bz2"))
The patch looks good to me, except the indentation of this
(string-append ...). I usually write 'source' fields like this:
(source (origin
(method url-fetch)
(uri (string-append "mirror://xorg/individual/util/lndir-"
version ".tar.bz2"))
(sha256
(base32
"0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
But this is not a big deal, of course :-)
> + (sha256
> + (base32
> + "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
> + (build-system gnu-build-system)
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (inputs
> + `(("xproto" ,xproto)))
> + (home-page "http://www.x.org")
> + (synopsis "Symlink directory into tree")
> + (description "Create a shadow directory of symbolic links to another
> +directory tree.")
> + (license license:x11)))
> +
> (define-public bdftopcf
> (package
> (name "bdftopcf")
--
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 08/24] gnu: xorg: Add lndir.
@ 2016-08-17 8:35 David Craven
2016-08-17 17:49 ` Alex Kost
0 siblings, 1 reply; 4+ messages in thread
From: David Craven @ 2016-08-17 8:35 UTC (permalink / raw)
To: guix-devel, Alex Kost
> The patch looks good to me, except the indentation of this
>
> (string-append ...). I usually write 'source' fields like this:
>
> (source (origin
> (method url-fetch)
> (uri (string-append "mirror://xorg/individual/util/lndir-"
> version ".tar.bz2"))
> (sha256
> (base32
> "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
>
> But this is not a big deal, of course :-)
I prefer
(uri (string-append
"mirror://xorg/individual/util/"
"lndir-" version ".tar.bz2"))
But in this case I thought that keeping consistent with how it was
done in the xorg.scm file was more important than my preference. What
do you think?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 08/24] gnu: xorg: Add lndir.
2016-08-17 8:35 [PATCH 08/24] gnu: xorg: Add lndir David Craven
@ 2016-08-17 17:49 ` Alex Kost
0 siblings, 0 replies; 4+ messages in thread
From: Alex Kost @ 2016-08-17 17:49 UTC (permalink / raw)
To: David Craven; +Cc: guix-devel
David Craven (2016-08-17 11:35 +0300) wrote:
>> The patch looks good to me, except the indentation of this
>>
>> (string-append ...). I usually write 'source' fields like this:
>>
>> (source (origin
>> (method url-fetch)
>> (uri (string-append "mirror://xorg/individual/util/lndir-"
>> version ".tar.bz2"))
>> (sha256
>> (base32
>> "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
>>
>> But this is not a big deal, of course :-)
>
> I prefer
> (uri (string-append
> "mirror://xorg/individual/util/"
> "lndir-" version ".tar.bz2"))
OK, but then it should be (note the indentation of 'string-append'):
(uri (string-append
"mirror://xorg/individual/util/"
"lndir-" version ".tar.bz2"))
> But in this case I thought that keeping consistent with how it was
> done in the xorg.scm file was more important than my preference. What
> do you think?
Many (probably most) packages in xorg.scm have bad indentation.
--
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-17 17:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-17 8:35 [PATCH 08/24] gnu: xorg: Add lndir David Craven
2016-08-17 17:49 ` Alex Kost
-- strict thread matches above, loose matches on Subject: below --
2016-08-16 18:39 [PATCH 01/24] gnu: qt: Add qtquickcontrols David Craven
2016-08-16 18:39 ` [PATCH 08/24] gnu: xorg: Add lndir David Craven
2016-08-16 19:53 ` Alex Kost
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.