* [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure.
2016-08-16 18:39 [PATCH 01/24] gnu: qt: Add qtquickcontrols David Craven
@ 2016-08-16 18:39 ` David Craven
2016-08-16 19:22 ` Danny Milosavljevic
0 siblings, 1 reply; 5+ messages in thread
From: David Craven @ 2016-08-16 18:39 UTC (permalink / raw)
To: guix-devel; +Cc: David Craven
* gnu/packages/kde-frameworks.scm (kwidgetsaddons)[arguments]:
Enable tests. Set Xvfb pixel depth to 24 bits.
---
gnu/packages/kde-frameworks.scm | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index e08b8cf..113257e 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -817,19 +817,19 @@ represented by a QPoint or a QSize.")
(inputs
`(("qtbase" ,qtbase)))
(arguments
- `(#:tests? #f ; FIXME: libGL error: failed to load driver: swrast.
- #:phases
+ `(#:phases
(modify-phases %standard-phases
(add-before 'check 'check-setup
(lambda* _
- (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; enable debug output
- (setenv "LIBGL_DEBUG" "verbose") ; enable debug output
(setenv "DBUS_FATAL_WARNINGS" "0")))
(add-before 'check 'start-xorg-server
(lambda* (#:key inputs #:allow-other-keys)
;; The test suite requires a running X server.
+ ;; Xvfb doesn't have proper glx support and needs a pixeldepth
+ ;; of 24 bit to avoid "libGL error: failed to load driver: swrast"
+ ;; "Could not initialize GLX"
(system (string-append (assoc-ref inputs "xorg-server")
- "/bin/Xvfb :1 &"))
+ "/bin/Xvfb :1 -screen 0 640x480x24 &"))
(setenv "DISPLAY" ":1")
#t)))))
(home-page "https://community.kde.org/Frameworks")
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure.
2016-08-16 18:39 ` [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure David Craven
@ 2016-08-16 19:22 ` Danny Milosavljevic
0 siblings, 0 replies; 5+ messages in thread
From: Danny Milosavljevic @ 2016-08-16 19:22 UTC (permalink / raw)
To: David Craven; +Cc: guix-devel
> (system (string-append (assoc-ref inputs "xorg-server")
> - "/bin/Xvfb :1 &"))
> + "/bin/Xvfb :1 -screen 0 640x480x24 &"))
Might
(setenv "QT_QPA_PLATFORM" "offscreen")
also be enough? Starting an Xvfb server and then not stopping it again is kinda ... extreme. Also, who says that :1 is free?
I can see that it was there before, but just to be sure...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure.
@ 2016-08-17 10:08 David Craven
2016-08-18 0:20 ` David Craven
2016-08-18 9:14 ` Danny Milosavljevic
0 siblings, 2 replies; 5+ messages in thread
From: David Craven @ 2016-08-17 10:08 UTC (permalink / raw)
To: guix-devel, Danny Milosavljevic
> Might (setenv "QT_QPA_PLATFORM" "offscreen") also be enough?
Interesting, that also fixes the problem, but causes a new one...
********* Start testing of KDualActionTest *********
Config: Using QtTest library 5.7.0, Qt 5.7.0
(x86_64-little_endian-lp64 shared (dynamic) release build; by GCC
4.9.3)
PASS : KDualActionTest::initTestCase()
PASS : KDualActionTest::testSetGuiItem()
FAIL! : KDualActionTest::testSetIconForStates() Compared pointers are
not the same
Actual (action.inactiveIcon()): (nil)
Expected (icon) : 0x65a4d0
Loc: [/tmp/guix-build-kwidgetsaddons-5.24.0.drv-0/kwidgetsaddons-5.24.0/autotests/kdualactiontest.cpp(56)]
PASS : KDualActionTest::testSetActive()
PASS : KDualActionTest::testTrigger()
PASS : KDualActionTest::cleanupTestCase()
Totals: 5 passed, 1 failed, 0 skipped, 0 blacklisted, 3ms
********* Finished testing of KDualActionTest *********
> Starting an Xvfb server and then not stopping it again is kinda ... extreme.
Since the tests are run in a container, I'd expect all processes started inside
the container to receive a sigterm when the container is (shutdown?).
> Also, who says that :1 is free?
Again since the tests are run in a container, I'd expect that there
isn't a xserver
running unless I explicitly start it.
Are my assumptions wrong?
Do you think it's worth tracking down the test failure when my solution works?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure.
2016-08-17 10:08 [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure David Craven
@ 2016-08-18 0:20 ` David Craven
2016-08-18 9:14 ` Danny Milosavljevic
1 sibling, 0 replies; 5+ messages in thread
From: David Craven @ 2016-08-18 0:20 UTC (permalink / raw)
To: guix-devel, Danny Milosavljevic
I'll withhold this patch pending further investigation.
Thank you!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure.
2016-08-17 10:08 [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure David Craven
2016-08-18 0:20 ` David Craven
@ 2016-08-18 9:14 ` Danny Milosavljevic
1 sibling, 0 replies; 5+ messages in thread
From: Danny Milosavljevic @ 2016-08-18 9:14 UTC (permalink / raw)
To: David Craven; +Cc: guix-devel
> Again since the tests are run in a container, I'd expect that there
> isn't a xserver
> running unless I explicitly start it.
>
> Are my assumptions wrong?
> Do you think it's worth tracking down the test failure when my solution works?
No, if that's the case it's fine to use Xvfb too. It's just that QT_QPA_PLATFORM would be a lot less compute-intensive.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-18 9:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-17 10:08 [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure David Craven
2016-08-18 0:20 ` David Craven
2016-08-18 9:14 ` Danny Milosavljevic
-- strict thread matches above, loose matches on Subject: below --
2016-08-16 18:39 [PATCH 01/24] gnu: qt: Add qtquickcontrols David Craven
2016-08-16 18:39 ` [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure David Craven
2016-08-16 19:22 ` Danny Milosavljevic
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.