From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Craven <david@craven.ch>
Subject: Re: [PATCH v2] gnu: Add rust
Date: Wed, 7 Sep 2016 10:48:21 +0200
Message-ID: <CAL1_immeBBJd6Ca9a01WuKhs27jRoqpyuOAY66R8JB4fBz+a2w@mail.gmail.com>
References: <1473227838-22277-1-git-send-email-eric.le.bihan.dev@free.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35774)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bhYWy-0003KI-Nw
	for guix-devel@gnu.org; Wed, 07 Sep 2016 04:48:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bhYWu-0000kz-H6
	for guix-devel@gnu.org; Wed, 07 Sep 2016 04:48:27 -0400
Received: from mail-yw0-x242.google.com ([2607:f8b0:4002:c05::242]:33998)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bhYWt-0000kP-AM
	for guix-devel@gnu.org; Wed, 07 Sep 2016 04:48:24 -0400
Received: by mail-yw0-x242.google.com with SMTP id j1so379856ywb.1
	for <guix-devel@gnu.org>; Wed, 07 Sep 2016 01:48:22 -0700 (PDT)
In-Reply-To: <1473227838-22277-1-git-send-email-eric.le.bihan.dev@free.fr>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Eric Le Bihan <eric.le.bihan.dev@free.fr>
Cc: guix-devel <guix-devel@gnu.org>

I haven't actually built rustc yet, because I know how long it takes...

> +                         (ld-so (string-append
> +                                 (assoc-ref inputs "libc")
> +                                 ,(glibc-dynamic-linker)))

> +                     ;; Remove reference to "/lib64/ld-linux-x86-64.so.2" from binary
> +                     (zero? (system*
> +                             "patchelf"
> +                             "--set-interpreter" ld-so

I think that this should be part of the a rustc-bootstrap package. We
shouldn't export binaries to the user, but I think we need a fully
functional bootstrap compiler.

> +                     (setenv "SHELL" (which "sh"))
> +                     (setenv "CONFIG_SHELL" (which "sh"))
> +                     ;; Tell where to find libgcc_s.so
> +                     (setenv "LD_LIBRARY_PATH" (string-append gcc-lib "/lib"))

I think this should be a separate phase. We can then use
#:configure-flags to pass --default-linker etc.

> +      #:tests? #f))

To get tests enabled you can apply this patch [0].

[0] https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/rust/patches/disable-lockfile-check.patch