all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Craven <david@craven.ch>
To: Eric Le Bihan <eric.le.bihan.dev@free.fr>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH v2] gnu: Add rust
Date: Wed, 7 Sep 2016 10:48:21 +0200	[thread overview]
Message-ID: <CAL1_immeBBJd6Ca9a01WuKhs27jRoqpyuOAY66R8JB4fBz+a2w@mail.gmail.com> (raw)
In-Reply-To: <1473227838-22277-1-git-send-email-eric.le.bihan.dev@free.fr>

I haven't actually built rustc yet, because I know how long it takes...

> +                         (ld-so (string-append
> +                                 (assoc-ref inputs "libc")
> +                                 ,(glibc-dynamic-linker)))

> +                     ;; Remove reference to "/lib64/ld-linux-x86-64.so.2" from binary
> +                     (zero? (system*
> +                             "patchelf"
> +                             "--set-interpreter" ld-so

I think that this should be part of the a rustc-bootstrap package. We
shouldn't export binaries to the user, but I think we need a fully
functional bootstrap compiler.

> +                     (setenv "SHELL" (which "sh"))
> +                     (setenv "CONFIG_SHELL" (which "sh"))
> +                     ;; Tell where to find libgcc_s.so
> +                     (setenv "LD_LIBRARY_PATH" (string-append gcc-lib "/lib"))

I think this should be a separate phase. We can then use
#:configure-flags to pass --default-linker etc.

> +      #:tests? #f))

To get tests enabled you can apply this patch [0].

[0] https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/rust/patches/disable-lockfile-check.patch

  reply	other threads:[~2016-09-07  8:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07  5:57 [PATCH v2] gnu: Add rust Eric Le Bihan
2016-09-07  8:48 ` David Craven [this message]
2016-09-13 11:55   ` [PATCH v2] gnu: Add rust (sidenotes on rust) ng0
2016-09-13 12:19     ` ng0
2016-09-13 12:28       ` David Craven
2016-09-13 12:09 ` [PATCH v2] gnu: Add rust ng0
2016-09-13 17:20   ` Eric Le Bihan
2016-09-13 18:29     ` ng0
2016-09-13 18:45       ` ng0
2016-09-13 19:11         ` ng0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL1_immeBBJd6Ca9a01WuKhs27jRoqpyuOAY66R8JB4fBz+a2w@mail.gmail.com \
    --to=david@craven.ch \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.