From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Craven Subject: Re: [PATCH] gnu: spice: Fix usbredir for 32 bit platforms. Date: Sun, 14 Aug 2016 20:50:36 +0200 Message-ID: References: <87d1llvq1t.fsf@netris.org> <20160808114649.11396-1-david@craven.ch> <877fbke9dy.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZ0Ue-0000hd-SK for guix-devel@gnu.org; Sun, 14 Aug 2016 14:50:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZ0Ua-0003eB-2s for guix-devel@gnu.org; Sun, 14 Aug 2016 14:50:44 -0400 Received: from mail-yw0-x22d.google.com ([2607:f8b0:4002:c05::22d]:36686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZ0UY-0003cV-Rr for guix-devel@gnu.org; Sun, 14 Aug 2016 14:50:40 -0400 Received: by mail-yw0-x22d.google.com with SMTP id u134so17435451ywg.3 for ; Sun, 14 Aug 2016 11:50:37 -0700 (PDT) In-Reply-To: <877fbke9dy.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel > Phase procedures are supposed to return a boolean indicating whether > they succeeded, but 'system*' returns a number: a result code. In > scheme, all numbers are considered true. Also, you might as well use > 'lambda' here instead of 'lambda*', so it should look like this: > (lambda _ > (zero? (system* "sh" "autogen.sh"))) The reason was that autogen.sh performs some check at the end that fails. I'm running autoreconf directly now, so that the zero? doesn't cause the phase to fail. > This is no longer version "0.7.1", so the version number needs to be > updated accordingly. Please see section 7.6.3 (Version Numbers) in the > manual for our conventions for version numbers of VCS snapshots, and the > recommended code to generate those version numbers. This could have also probably survived until the package gets updated, but I fixed it. > It might have been better to just use a simple patch to fix the format > strings than to use a VCS snapshot that might introduce more bugs, but > I guess we can see how it goes. I considered this option also, but in at least one instance I was asked to use substitute* instead of a patch, so I thought that patches are considered a last resort. I also checked the history before selecting HEAD as the commit, it looks like there where only a couple of bugfixes, but not much activity otherwise. So hopefully this does not introduce any new bugs. Thanks, David