From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Craven <david@craven.ch>
Subject: Re: [PATCH] gnu: Add nim.
Date: Mon, 9 Jan 2017 18:09:17 +0100
Message-ID: <CAL1_imkxD3LXFyzDtV3_YmgPNWTAS8SYs3zBXxz_uWH9Sd7T+g@mail.gmail.com>
References: <1db124bbe9a402a81340934da1c98eb5@openmailbox.org>
	<7a7cfa2db2b667561bb356156ad8682e@openmailbox.org>
	<48b6abba5d87ed52472f92ee190d25a2@openmailbox.org>
	<9dd319dec66e1f4e5d4eff5289941115@openmailbox.org>
	<CAL1_imnt0oAi08-aR_qCmWJLoKth7GkTv3sYuRq7MQmdn61VLA@mail.gmail.com>
	<6ff4e48ed27418388191f45be561dba0@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57859)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1cQdRi-0006RY-Dh
	for guix-devel@gnu.org; Mon, 09 Jan 2017 12:09:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1cQdRe-00088A-8h
	for guix-devel@gnu.org; Mon, 09 Jan 2017 12:09:22 -0500
Received: from mail-qt0-x22a.google.com ([2607:f8b0:400d:c0d::22a]:36054)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <david@craven.ch>) id 1cQdRe-00087o-4P
	for guix-devel@gnu.org; Mon, 09 Jan 2017 12:09:18 -0500
Received: by mail-qt0-x22a.google.com with SMTP id k15so371324620qtg.3
	for <guix-devel@gnu.org>; Mon, 09 Jan 2017 09:09:18 -0800 (PST)
In-Reply-To: <6ff4e48ed27418388191f45be561dba0@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?UTF-8?B?Sm9zw6kgTWlndWVsIFPDoW5jaGV6IEdhcmPDrWE=?= <jmi2k@openmailbox.org>
Cc: guix-devel <guix-devel@gnu.org>

Hi Jose,

Some changes I made:

* change module name to (gnu packages nim).
* reorder imports alphabetically.
* added you to the copyright header.
* added a comment as to why the tests are disabled.
* returned true after substitute*
* used (zero? (system* "./install.sh" ...
* removed new line after description
* added a trailing dot to the commit message headline

I don't think we need a separate /opt subfolder, opt is basically
/gnu/store for FHS systems.

Pushed as 84aafbbb664925ed1a9de3e53238bc54c743a968. Thank you!