From: David Craven <david@craven.ch>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 3/3] gnu: Add openocd.
Date: Wed, 26 Oct 2016 14:49:00 +0200 [thread overview]
Message-ID: <CAL1_imkRRzbvZ7ykQszDP7x9YdjriuAZOg8iE50Bj84z9P6SaA@mail.gmail.com> (raw)
In-Reply-To: <20161025132615.20705-4-theodoros.for@openmailbox.org>
Hi Theodoros,
Do we really need this patch? Is there a reason why it hasn't been
upstreamed yet?
(add-before 'configure 'bootstrap
+ (lambda _
+ (system* "aclocal")
+ (system* "libtoolize" "--automake" "--copy")
+ (system* "autoconf")
+ (system* "autoheader")
+ (system* "automake" "--gnu" "--add-missing" "--copy")
+ #t))
Why not (add-before 'configure 'autoreconf
(lambda _
(zero? (system* "autoreconf" "-vfi"))
I prefer indenting like this as is done in most of the codebase:
+ (inputs
`(("libusb" ,libusb)
+ ("libusb-compat" ,libusb-compat)
+ ("libftdi" ,libftdi)
+ ("hidapi" ,hidapi)))
+ (native-inputs
`(("autoconf" ,autoconf)
+ ("libtool" ,libtool)
+ ("automake" ,automake)
+ ("pkg-config" ,pkg-config)))
It would also be nice if the inputs where ordered alphabetically.
Thanks for the patch, looking good!! You don't need to resubmit
(unless someone else has more objections :).
David
next prev parent reply other threads:[~2016-10-26 12:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 13:26 [PATCH 0/3] gnu: Add gdb-arm-none-eabi and openocd Theodoros Foradis
2016-10-25 13:26 ` [PATCH 1/3] gnu: Add gdb-arm-none-eabi Theodoros Foradis
2016-10-26 12:57 ` David Craven
2016-10-25 13:26 ` [PATCH 2/3] gnu: Add hidapi Theodoros Foradis
2016-10-26 12:55 ` David Craven
2016-10-26 18:29 ` Theodoros Foradis
2016-10-26 18:50 ` David Craven
2016-10-25 13:26 ` [PATCH 3/3] gnu: Add openocd Theodoros Foradis
2016-10-26 12:49 ` David Craven [this message]
2016-10-26 21:08 ` [PATCH v2 0/3] gnu: Add gdb-arm-none-eabi and openocd Theodoros Foradis
2016-10-26 21:08 ` [PATCH v2 1/3] gnu: Add gdb-arm-none-eabi Theodoros Foradis
2016-10-26 21:08 ` [PATCH v2 2/3] gnu: Add hidapi Theodoros Foradis
2016-10-28 6:19 ` Ricardo Wurmus
2016-10-28 15:35 ` Theodoros Foradis
2016-10-26 21:08 ` [PATCH v2 3/3] gnu: Add openocd Theodoros Foradis
2016-10-27 6:24 ` Efraim Flashner
2016-10-28 6:14 ` Ricardo Wurmus
2016-10-28 17:36 ` Theodoros Foradis
2016-10-28 17:36 ` [PATCH v3 1/3] gnu: Add gdb-arm-none-eabi Theodoros Foradis
2016-10-28 17:36 ` [PATCH v3 2/3] gnu: Add hidapi Theodoros Foradis
2016-11-09 15:45 ` Ludovic Courtès
2016-10-28 17:36 ` [PATCH v3 3/3] gnu: Add openocd Theodoros Foradis
2016-10-30 1:40 ` David Craven
2016-10-30 5:34 ` Ricardo Wurmus
2016-10-30 13:05 ` David Craven
2016-10-30 18:18 ` Ricardo Wurmus
2016-10-30 18:19 ` David Craven
2016-10-30 18:24 ` Ricardo Wurmus
2017-02-13 19:44 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL1_imkRRzbvZ7ykQszDP7x9YdjriuAZOg8iE50Bj84z9P6SaA@mail.gmail.com \
--to=david@craven.ch \
--cc=guix-devel@gnu.org \
--cc=theodoros.for@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.