From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Craven Subject: Re: [PATCH v2 1/2] gnu: Add dtc. Date: Thu, 1 Sep 2016 17:16:19 +0200 Message-ID: References: <20160831213437.31115-1-dannym@scratchpost.org> <20160831213437.31115-2-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfTjB-00009Y-7O for guix-devel@gnu.org; Thu, 01 Sep 2016 11:16:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfTj5-0002YB-6G for guix-devel@gnu.org; Thu, 01 Sep 2016 11:16:28 -0400 Received: from mail-yb0-x244.google.com ([2607:f8b0:4002:c09::244]:36554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfTj3-0002Xl-Sw for guix-devel@gnu.org; Thu, 01 Sep 2016 11:16:23 -0400 Received: by mail-yb0-x244.google.com with SMTP id f60so1808797ybi.3 for ; Thu, 01 Sep 2016 08:16:20 -0700 (PDT) In-Reply-To: <20160831213437.31115-2-dannym@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel So I'm ready to push dtc and u-boot. I'm still not sure about the patches. If you want me to add them I think you should send a new patch. I see you dropped the uboot prefix from the patch names. The patch names also need to be updated in local.mk. I think that the 01 23 and 24 should be dropped, probably the libfdt too. The patch names we have so far stick to lowercase patch names, so we should too. And use - everywhere. So that would be dtc-build-doc.patch, dtc-add-missing-function-to-shared-library.patch and dtc-add-some-missing-symbols-to-lds.patch. If you make the changes I'll push your patch. Thank you for your contribution! David