[PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

[PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

[David Craven]

* gnu/packages/kde-frameworks.scm (networkmanager-qt)
  [propagated-inputs]: Add NETWORK-MANAGER.
  [inputs]: Remove NETWORK-MANAGER.
---
 gnu/packages/kde-frameworks.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index dbec5a3..61ed4aa 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -934,9 +934,10 @@ messages.")
       `(("extra-cmake-modules" ,extra-cmake-modules)
         ("dbus" ,dbus)
         ("pkg-config" ,pkg-config)))
+     (propagated-inputs
+      `(("network-manager", network-manager)))
      (inputs
-      `(("network-manager", network-manager)
-        ("qtbase" ,qtbase)))
+      `(("qtbase" ,qtbase)))
      (arguments
       `(#:phases
          (modify-phases %standard-phases
-- 
2.9.0

Re: [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

[Alex Kost]

David Craven (2016-08-16 21:39 +0300) wrote:

> * gnu/packages/kde-frameworks.scm (networkmanager-qt)
>   [propagated-inputs]: Add NETWORK-MANAGER.
>   [inputs]: Remove NETWORK-MANAGER.

I would write 'network-manager' instead of NETWORK-MANAGER.

Also there should be a reason for propagating (probably written as a
comment).  Ideally it should be avoided.

> ---
>  gnu/packages/kde-frameworks.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index dbec5a3..61ed4aa 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -934,9 +934,10 @@ messages.")
>        `(("extra-cmake-modules" ,extra-cmake-modules)
>          ("dbus" ,dbus)
>          ("pkg-config" ,pkg-config)))
> +     (propagated-inputs
> +      `(("network-manager", network-manager)))
                             ↑↑
BTW please fix the comma placement here:
                             ↓↓
         `(("network-manager" ,network-manager)))

>       (inputs
> -      `(("network-manager", network-manager)
> -        ("qtbase" ,qtbase)))
> +      `(("qtbase" ,qtbase)))
>       (arguments
>        `(#:phases
>           (modify-phases %standard-phases

-- 
Alex

Re: [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

[David Craven]

> Also there should be a reason for propagating (probably written as a
> comment).  Ideally it should be avoided.

I added comments:

(propagated-inputs
      ; Headers contain #include <NetworkManager.h> and
      ;                            #include <libnm/NetworkManager.h>
      `(("network-manager" ,network-manager)))

(propagated-inputs
     ; Headers contain #include <ModemManager/ModemManager.h>
     `(("modem-manager", modem-manager)))

Re: [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

[Alex Kost]

David Craven (2016-08-17 12:34 +0300) wrote:

>> Also there should be a reason for propagating (probably written as a
>> comment).  Ideally it should be avoided.
>
> I added comments:
>
> (propagated-inputs
>       ; Headers contain #include <NetworkManager.h> and
>       ;                            #include <libnm/NetworkManager.h>
>       `(("network-manager" ,network-manager)))
>
> (propagated-inputs
>      ; Headers contain #include <ModemManager/ModemManager.h>
>      `(("modem-manager", modem-manager)))

These comments should begin with ";;", not with ";".  Sorry, but I still
don't understand the reason.  What exactly does not work when these are
simple inputs?  Is it possible to avoid propagating?

-- 
Alex

Re: [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

[David Craven]

> Is it possible to avoid propagating?

Quoting the manual on the section on propagated-inputs:

> For example this is necessary when a C/C++ library needs headers of another library to compile, ...

So the fact that the headers of networkmanager-qt include headers from
network-manager, means that a library that uses networkmanager-qt also
needs network-manager's header files. After compilation if there
aren't any references to network-manager it won't be included in the
RUNPATH.

> or when a pkg-config file refers to another one via its Requires field.

I think the equivalent for cmake packages is a find_dependency call
inside of /lib/cmake. In this case a library that links agains
networkmanager-qt doesn't need to link agains network-manager.

> find_dependency(Qt5Core 5.4.0)

So to build hawaii-shell that depends on networkmanager-qt I either
have to add network-manager as an input or propagate it in
networkmanager-qt. I don't think that propagating the input hurts:

guix gc --references $(guix build hawaii-shell)         ~/guix
/gnu/store/1i3xmm18dw9kq6wi46f6sj9nxy9pckjl-alsa-lib-1.0.27.1
/gnu/store/3a3qhlr9ssczrkjr10jllb01mbdgsijp-pulseaudio-8.0
/gnu/store/8advwv6y780wf8l4inmrm4vzrqd56z5b-libxkbcommon-0.6.1
/gnu/store/9jfrsgr6jw9hzqj81p3vn632m79x5gla-wayland-1.11.0
/gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib
/gnu/store/b8c1aaw3nghvvw6w6hc7r701rg40f5qw-qtdeclarative-5.7.0
/gnu/store/bski0qimql11q9b86h8jhhyksk1z52vp-greenisland-0.8.90
/gnu/store/hnbnz18xkkq83ckk2ph8qgbc8z4qzm6f-qtbase-5.7.0
/gnu/store/ig30hr17jq27b8wnimf9lnksgk6q4k7f-hawaii-shell-0.7.1
/gnu/store/l1s4cw9g58hmcpd2qgbckfl228143qzx-glib-2.48.0
/gnu/store/l878cqim3hl8mj7iz5a2v3mv1zn81qyr-solid-5.24.0
/gnu/store/lyisag3k6wx0pmrd0al0ipgcqaf0hpwi-qtwayland-5.7.0
/gnu/store/m4xna3zq2il5an61wxbmfv82ndvz70f6-linux-pam-1.2.1
/gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23
/gnu/store/n3jss47pj11zq1viyibfcg0jf0ag519s-mesa-12.0.0
/gnu/store/qh2q5h2b81562ji5i9kb4nhg74gzk7n9-libhawaii-0.8.0
/gnu/store/qz5d1c538qigsws9k8hlys2hvhvbfrpc-networkmanager-qt-5.24.0
/gnu/store/r129q7kkd28xrp0slw2dqgmbs608gcgv-libqtxdg-1.2.0
/gnu/store/ykzwykkvr2c80rw4l1qh3mvfdkl7jibi-bash-4.3.42
/gnu/store/zvg8qyjsz20vjd170h4ilk7pnv7bqmm6-eudev-3.1.5

WDYT?

Re: [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

[Alex Kost]

David Craven (2016-08-17 21:14 +0300) wrote:

>> Is it possible to avoid propagating?
>
> Quoting the manual on the section on propagated-inputs:
>
>> For example this is necessary when a C/C++ library needs headers of another library to compile, ...
>
> So the fact that the headers of networkmanager-qt include headers from
> network-manager, means that a library that uses networkmanager-qt also
> needs network-manager's header files. After compilation if there
> aren't any references to network-manager it won't be included in the
> RUNPATH.

Ah, OK, I didn't know that, thanks for pointing!

-- 
Alex