all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Craven <david@craven.ch>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 1/2] system: Rename grub to bootloader.
Date: Thu, 12 Jan 2017 15:45:53 +0100	[thread overview]
Message-ID: <CAL1_im=qT68BGm5vqtRX6r6O2ZKpwqaSVe1rqo-ScMTQ9R91=g@mail.gmail.com> (raw)
In-Reply-To: <87bmvc4b85.fsf@gnu.org>

I agree on this patch. The renaming is not very good and breaks
things. It needs to be done in smaller steps. The one that renames the
flag could be done dough, since that doesn't break anything and
changes the cli interface. The sooner we can do that the better IMO,
because it is a user facing change.

I need to study for my exams the next week or two, but my current
thinking on the next steps to accomplish the goal of being bootloader
agnostic are:

1. discard <menu-entry> in gnu/system/grub in favor of
<boot-parameters> from gnu/system - small api changes

2. focus on the code in gnu/system/vm.scm and gnu/build/vm.scm. A lot
of decisions are being made about the qemu package, the qemu flags,
the file-system, the bootloader, the architecture and the kernel etc.
that should be moved elsewhere. - will affect guix/scripts/system and
probably the system tests infrastructure, the existing api should be
kept to avoid breakage in those parts.

Currently using a different bootloader affects far to many parts of
the codebase.

Do you think that (in general) adding new code to gnu/build is still a
valid design choice or do you consider it a better idea to turn most
of the code from gnu/build incrementally into gexps in gnu/system?

  reply	other threads:[~2017-01-12 14:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 18:42 [PATCH 1/2] system: Rename grub to bootloader David Craven
2017-01-10 18:42 ` [PATCH 2/2] scripts: system: Rename --no-grub option to --no-bootloader David Craven
2017-01-10 23:10   ` Danny Milosavljevic
2017-01-11  8:23     ` David Craven
2017-01-10 18:51 ` [PATCH 1/2] system: Rename grub to bootloader David Craven
2017-01-12 14:14   ` Ludovic Courtès
2017-01-12 14:45     ` David Craven [this message]
2017-01-14 17:40       ` Ludovic Courtès
2017-01-13  6:06     ` Chris Marusich
2017-01-10 23:01 ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL1_im=qT68BGm5vqtRX6r6O2ZKpwqaSVe1rqo-ScMTQ9R91=g@mail.gmail.com' \
    --to=david@craven.ch \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.