From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Craven Subject: Re: Linux kernel Date: Sat, 10 Sep 2016 00:48:04 +0200 Message-ID: References: <87eg4sr9os.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biUai-0001uy-IJ for guix-devel@gnu.org; Fri, 09 Sep 2016 18:48:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biUae-0000rV-A4 for guix-devel@gnu.org; Fri, 09 Sep 2016 18:48:11 -0400 Received: from mail-yw0-x233.google.com ([2607:f8b0:4002:c05::233]:34408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biUad-0000r9-11 for guix-devel@gnu.org; Fri, 09 Sep 2016 18:48:08 -0400 Received: by mail-yw0-x233.google.com with SMTP id g192so55912251ywh.1 for ; Fri, 09 Sep 2016 15:48:05 -0700 (PDT) In-Reply-To: <87eg4sr9os.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel > Seems we already discussed some of these, no? Ah yes, I missed this, sorry - No need to comment on this patch again: >> Important note: (%current-target-system) returns a GNU triplet such as >> =E2=80=9Carm-linux-gnueabihf=E2=80=9D, whereas (%current-system) returns= a =E2=80=9Csystem type=E2=80=9D >> such as =E2=80=9Carmhf-linux=E2=80=9D. >> In practice it works here, and =E2=80=98linux-libre-headers=E2=80=99 alr= eady does that, >> so this patch is OK (can go to master). >> However, we should augment the docstring of =E2=80=98system->linux-archi= tecture=E2=80=99 >> to clarify that it accepts both a triplet and a system string. Could >> you do that? > Anyway, I=E2=80=99m fine with you sending the remaining patches with =E2= =80=98git > send-email=E2=80=99; it makes it easier to comment on the code for me. Done. > Nitpick: Use =E2=80=98base32=E2=80=99 here, rather than in the callee (th= at way, base32 > parsing happens at compile time and errors are detected early.) Good to know, I wondered why we always need sha256 and base32 :-)