From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Craven <david@craven.ch>
Subject: Re: [PATCH 2/3] gnu: Add hidapi.
Date: Wed, 26 Oct 2016 20:50:43 +0200
Message-ID: <CAL1_im=eGqzMHVBkUyzpCTTz+QbM3xA0kEfeQDEr3GJ9fAJJRA@mail.gmail.com>
References: <20161025132615.20705-1-theodoros.for@openmailbox.org>
	<20161025132615.20705-3-theodoros.for@openmailbox.org>
	<CAL1_imnGMHJoikvoe1zOuOY51CcO3Mrxcy1J7gjXT0-BnhhDWw@mail.gmail.com>
	<87h97zt15c.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55222)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bzTIi-0000Xa-Bg
	for guix-devel@gnu.org; Wed, 26 Oct 2016 14:51:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bzTIf-0005Q1-8Q
	for guix-devel@gnu.org; Wed, 26 Oct 2016 14:51:48 -0400
Received: from mail-qk0-f195.google.com ([209.85.220.195]:34269)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <david@craven.ch>) id 1bzTIf-0005Pu-3o
	for guix-devel@gnu.org; Wed, 26 Oct 2016 14:51:45 -0400
Received: by mail-qk0-f195.google.com with SMTP id n189so822494qke.1
	for <guix-devel@gnu.org>; Wed, 26 Oct 2016 11:51:44 -0700 (PDT)
In-Reply-To: <87h97zt15c.fsf@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: Guix-devel <guix-devel@gnu.org>

> There is no configure script in the release tarball, so I think we
> either need this or:

Ah ok then... (zero? (system* "autoreconf" "-vfi")) might be nicer
than (system* "./bootstrap.sh") but doesn't really matter. I thought
that when you create a tarball with `make dist` the configure file is
included.

> What am I missing?

I'm not sure if you mean in regard to the license or the input indentation.

With input indentation I mean the same I wrote on the openocd patch:
(native-inputs
  `(("autoconf" ,autoconf)
     ("libtool" ,libtool)

LICENSE-gpl3.txt says:
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or (at
your option) any later version.

I didn't see that there are three other license files too, those
should be mentioned then.