From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Craven Subject: Re: [PATCH 2/6] gnu: %default-extra-linux-options: Remove redundant options. Date: Thu, 29 Sep 2016 10:53:57 +0200 Message-ID: References: <20160926103447.31830-1-david@craven.ch> <20160926103447.31830-2-david@craven.ch> <87r3839jzb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f403045db38649802f053da19e0c Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:32846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpX6V-0001ve-1R for guix-devel@gnu.org; Thu, 29 Sep 2016 04:54:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpX6P-0004Yi-86 for guix-devel@gnu.org; Thu, 29 Sep 2016 04:54:06 -0400 Received: from mail-yb0-x243.google.com ([2607:f8b0:4002:c09::243]:33939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpX6O-0004YQ-02 for guix-devel@gnu.org; Thu, 29 Sep 2016 04:54:01 -0400 Received: by mail-yb0-x243.google.com with SMTP id z8so764558ybh.1 for ; Thu, 29 Sep 2016 01:53:58 -0700 (PDT) In-Reply-To: <87r3839jzb.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel --f403045db38649802f053da19e0c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I'll look at it I'm ca 1h afk. That's possible, the kernel configs may use y instead of m, but I checked that they're all there. I think that the configs should probably be changed, or wdyt? On Sep 29, 2016 10:41 AM, "Ludovic Court=C3=A8s" wrote: > Hi David, > > David Craven skribis: > > > * gnu/packages/linux.scm (%default-extra-linux-options): Remove > > redundant options. > > This patches appears to break things: > > --8<---------------cut here---------------start------------->8--- > $ sudo ./pre-inst-env guix system reconfigure ~/src/configuration/pluto-c= onfiguration.scm > --fallback > > [...] > > Backtrace: > In ice-9/boot-9.scm: > 157: 13 [catch #t # ...] > In unknown file: > ?: 12 [apply-smob/1 #] > In ice-9/boot-9.scm: > 63: 11 [call-with-prompt prompt0 ...] > In ice-9/eval.scm: > 432: 10 [eval # #] > In ice-9/boot-9.scm: > 2401: 9 [save-module-excursion # ice-9/boot-9.scm:4045:3 ()>] > 4050: 8 [#] > 1724: 7 [%start-stack load-stack # ice-9/boot-9.scm:4041:10 ()>] > 1729: 6 [#] > In unknown file: > ?: 5 [primitive-load "/gnu/store/8lmcdhipd7ccjpaqd3a8pbb2yvn9d7 > v0-linux-modules-builder"] > In ice-9/eval.scm: > 432: 4 [eval # ()] > 453: 3 [eval # ()] > 411: 2 [eval # ()] > In srfi/srfi-1.scm: > 578: 1 [map # ("ahci" "usb-storage" "uas" ...)] > In unknown file: > ?: 0 [scm-error misc-error #f ...] > > ERROR: In procedure scm-error: > ERROR: module not found "virtio_pci.ko" "/gnu/store/ > kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/modules" > builder for `/gnu/store/x0jqyr639karxakl0q2807ka608g4k3n-linux-modules.dr= v' > failed with exit code 1 > --8<---------------cut here---------------end--------------->8--- > > =E2=80=9Cmake check-system TESTS=3Dbasic=E2=80=9D fails similarly. > > Indeed, most of the virtio modules disappeared: > > --8<---------------cut here---------------start------------->8--- > $ find "/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib= /modules" > -name virtio\* > /gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/ > modules/4.7.5-gnu/kernel/drivers/char/hw_random/virtio-rng.ko > /gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/ > modules/4.7.5-gnu/kernel/drivers/scsi/virtio_scsi.ko > /gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/ > modules/4.7.5-gnu/kernel/drivers/gpu/drm/virtio > /gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/ > modules/4.7.5-gnu/kernel/drivers/gpu/drm/virtio/virtio-gpu.ko > /gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/ > modules/4.7.5-gnu/kernel/drivers/virtio > /gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/ > modules/4.7.5-gnu/kernel/drivers/virtio/virtio_input.ko > --8<---------------cut here---------------end--------------->8--- > > I think we need to revert this patch. Could you please look at it? > > TIA! > > Ludo=E2=80=99. > --f403045db38649802f053da19e0c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

I'll look at it I'm ca 1h afk. That's possible, = the kernel configs may use y instead of m, but I checked that they're a= ll there. I think that the configs should probably be changed, or wdyt?


On Sep 29, 2016 1= 0:41 AM, "Ludovic Court=C3=A8s" <ludo@gnu.org> wrote:
Hi David,

David Craven <david@craven.ch>= skribis:

> * gnu/packages/linux.scm (%default-extra-linux-options): Remove >=C2=A0 =C2=A0redundant options.

This patches appears to break things:

--8<---------------cut here---------------start------------->8--= -
$ sudo ./pre-inst-env guix system reconfigure ~/src/configuration/pluto-configuration.scm --fallback

[...]

Backtrace:
In ice-9/boot-9.scm:
=C2=A0157: 13 [catch #t #<catch-closure 8c9aa0> ...]
In unknown file:
=C2=A0 =C2=A0?: 12 [apply-smob/1 #<catch-closure 8c9aa0>]
In ice-9/boot-9.scm:
=C2=A0 63: 11 [call-with-prompt prompt0 ...]
In ice-9/eval.scm:
=C2=A0432: 10 [eval # #]
In ice-9/boot-9.scm:
2401: 9 [save-module-excursion #<procedure 8e7800 at ice-9/boot-9.scm:40= 45:3 ()>]
4050: 8 [#<procedure 8e7800 at ice-9/boot-9.scm:4045:3 ()>]
1724: 7 [%start-stack load-stack #<procedure 8faae0 at ice-9/boot-9.scm:= 4041:10 ()>]
1729: 6 [#<procedure 8fd9c0 ()>]
In unknown file:
=C2=A0 =C2=A0?: 5 [primitive-load "/gnu/store/8lmcdhipd7ccjpaqd3a= 8pbb2yvn9d7v0-linux-modules-builder"]
In ice-9/eval.scm:
=C2=A0432: 4 [eval # ()]
=C2=A0453: 3 [eval # ()]
=C2=A0411: 2 [eval # ()]
In srfi/srfi-1.scm:
=C2=A0578: 1 [map #<procedure lookup (a)> ("ahci" "usb= -storage" "uas" ...)]
In unknown file:
=C2=A0 =C2=A0?: 0 [scm-error misc-error #f ...]

ERROR: In procedure scm-error:
ERROR: module not found "virtio_pci.ko" "/gnu/store/kzi= a9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib/modules"=
builder for `/gnu/store/x0jqyr639karxakl0q2807ka608g4k3n-linux-mo= dules.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8--= -

=E2=80=9Cmake check-system TESTS=3Dbasic=E2=80=9D fails similarly.

Indeed, most of the virtio modules disappeared:

--8<---------------cut here---------------start------------->8--= -
$ find "/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-li= bre-4.7.5/lib/modules" -name virtio\*
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib= /modules/4.7.5-gnu/kernel/drivers/char/hw_random/virtio-rng.= ko
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib= /modules/4.7.5-gnu/kernel/drivers/scsi/virtio_scsi.ko
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib= /modules/4.7.5-gnu/kernel/drivers/gpu/drm/virtio
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib= /modules/4.7.5-gnu/kernel/drivers/gpu/drm/virtio/virtio-gpu.= ko
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib= /modules/4.7.5-gnu/kernel/drivers/virtio
/gnu/store/kzia9krx5ax1pm2pq5476v5fv71x36ai-linux-libre-4.7.5/lib= /modules/4.7.5-gnu/kernel/drivers/virtio/virtio_input.ko
--8<---------------cut here---------------end--------------->8--= -

I think we need to revert this patch.=C2=A0 Could you please look at it?
TIA!

Ludo=E2=80=99.
--f403045db38649802f053da19e0c--