Re: 02/11: activation: Allow home directories to be created under /var/lib.

Re: 02/11: activation: Allow home directories to be created under /var/lib.

[Leo Famulari]

On Tue, Sep 06, 2016 at 03:53:17PM +0000, David Craven wrote:
> commit 6526d43ea4fb0cd151a0d5e9a072c651c1c963d1
> Author: David Craven <david@craven.ch>
> Date:   Fri Aug 26 21:45:57 2016 +0200
> 
>     activation: Allow home directories to be created under /var/lib.
>     
>     * gnu/build/activation.scm (activate-user+groups): Make sure /var/lib
>       exists.
> ---
>  gnu/build/activation.scm |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/gnu/build/activation.scm b/gnu/build/activation.scm
> index 10aa58d..7dc40b0 100644
> --- a/gnu/build/activation.scm
> +++ b/gnu/build/activation.scm
> @@ -233,6 +233,9 @@ numeric gid or #f."
>    ;; 'groupadd' aborts if the file doesn't already exist.
>    (touch "/etc/group")
>  
> +  ;; Allow home directories to be created under /var/lib.
> +  (mkdir "/var/lib")
> +
>    ;; Create the root account so we can use 'useradd' and 'groupadd'.
>    (activate-user (find (match-lambda
>                          ((name (? zero?) _ ...) #t)
> 

This would fail when /var/lib already existed. I fixed it by using
mkdir-p in a7199b7d994433eaabb989690887b921d053d761.

Yesterday was my first time using the system tests:
https://www.gnu.org/software/guix/manual/html_node/Running-the-Test-Suite.html#Running-the-Test-Suite

I assume they would have caught this, but I'm not sure. They definitely
would have caught my breakage of GRUB when I updated QEMU recently ;)

Re: 02/11: activation: Allow home directories to be created under /var/lib.

[David Craven]

>> +  (mkdir-p "/var/lib")

>‘mkdir’ should be enough.

I initially used mkdir-p...

Re: 02/11: activation: Allow home directories to be created under /var/lib.

[Ludovic Courtès]

David Craven <david@craven.ch> skribis:

>>> +  (mkdir-p "/var/lib")
>
>>‘mkdir’ should be enough.
>
> I initially used mkdir-p...

My bad, sorry!

Ludo’.