From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Craven Subject: Re: Patch to rename NIX_CONF_DIR to GUIX_CONF_DIR Date: Fri, 24 Jun 2016 17:02:55 +0200 Message-ID: References: <87oa6q6aln.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGSdM-0006sX-HW for guix-devel@gnu.org; Fri, 24 Jun 2016 11:03:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGSdH-0000CV-Cs for guix-devel@gnu.org; Fri, 24 Jun 2016 11:03:03 -0400 Received: from mail-yw0-x236.google.com ([2607:f8b0:4002:c05::236]:36467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGSdG-0000AI-4n for guix-devel@gnu.org; Fri, 24 Jun 2016 11:02:59 -0400 Received: by mail-yw0-x236.google.com with SMTP id b72so102272710ywa.3 for ; Fri, 24 Jun 2016 08:02:56 -0700 (PDT) In-Reply-To: <87oa6q6aln.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel@gnu.org Did you have a test failure? I get one on `tests/substitute.scm`. After `sudo guix archive --generate-key` I still get a test failure, but `sudo make check TESTS=3D"tests/substitute.scm"` remedied it. Who's supposed to own the keys? A private key in /etc shouldn't be owned by anyone other than root should it? But I don't think this has anything to do with my patch so I don't know why you'd get this failure. I don't think I missed any references, quoting ng0: > nix/libstore/globals.cc | 2 +- > nix/local.mk | 2 +- Are there any other references? That would be a serious bug in my text editor ;-) On Fri, Jun 24, 2016 at 2:21 PM, Ludovic Court=C3=A8s wrote: > Hello! > > David Craven skribis: > >> First I have to say `guix build guix --with-source=3D.` is totally aweso= me!! > > Thanks! Don=E2=80=99t miss --with-input too! ;-) > > https://www.gnu.org/software/guix/manual/html_node/Package-Transformati= on-Options.html > >> I couldn't find any documentation on the git commit message >> convention, hope I did it right. > > ng0 already replied on that point; you=E2=80=99re almost there. :-) > > The patch omits to change references to =E2=80=98NIX_CONF_DIR=E2=80=99 in= the *.cc and > *.h files under nix/. Could you update it accordingly? > > While at it, can you make it =E2=80=98GUIX_CONFIGURATION_DIRECTORY=E2=80= =99 instead of > =E2=80=98GUIX_CONF_DIR=E2=80=99 (following the Scheme tradition of avoidi= ng > abbreviations ;-))? > > Last, please run the test suite to make sure nothing goes wrong: > > https://www.gnu.org/software/guix/manual/html_node/Running-the-Test-Sui= te.html > > Thank you for looking into it! > > Ludo=E2=80=99.