From: David Craven <david@craven.ch>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: Patch to rename NIX_CONF_DIR to GUIX_CONF_DIR
Date: Fri, 24 Jun 2016 17:02:55 +0200 [thread overview]
Message-ID: <CAL1_im=HWS6ApruxWiv2xVcQ7VpERcLn9=2DxbyQMGFeB2YJWQ@mail.gmail.com> (raw)
In-Reply-To: <87oa6q6aln.fsf@gnu.org>
Did you have a test failure? I get one on `tests/substitute.scm`.
After `sudo guix archive --generate-key` I still get a test failure,
but `sudo make check TESTS="tests/substitute.scm"` remedied it.
Who's supposed to own the keys? A private key in /etc shouldn't be
owned by anyone other than root should it?
But I don't think this has anything to do with my patch so I don't know
why you'd get this failure.
I don't think I missed any references, quoting ng0:
> nix/libstore/globals.cc | 2 +-
> nix/local.mk | 2 +-
Are there any other references? That would be a serious bug in my text
editor ;-)
On Fri, Jun 24, 2016 at 2:21 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> Hello!
>
> David Craven <david@craven.ch> skribis:
>
>> First I have to say `guix build guix --with-source=.` is totally awesome!!
>
> Thanks! Don’t miss --with-input too! ;-)
>
> https://www.gnu.org/software/guix/manual/html_node/Package-Transformation-Options.html
>
>> I couldn't find any documentation on the git commit message
>> convention, hope I did it right.
>
> ng0 already replied on that point; you’re almost there. :-)
>
> The patch omits to change references to ‘NIX_CONF_DIR’ in the *.cc and
> *.h files under nix/. Could you update it accordingly?
>
> While at it, can you make it ‘GUIX_CONFIGURATION_DIRECTORY’ instead of
> ‘GUIX_CONF_DIR’ (following the Scheme tradition of avoiding
> abbreviations ;-))?
>
> Last, please run the test suite to make sure nothing goes wrong:
>
> https://www.gnu.org/software/guix/manual/html_node/Running-the-Test-Suite.html
>
> Thank you for looking into it!
>
> Ludo’.
next prev parent reply other threads:[~2016-06-24 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 19:07 Patch to rename NIX_CONF_DIR to GUIX_CONF_DIR David Craven
2016-06-23 22:44 ` ng0
2016-06-24 12:21 ` Ludovic Courtès
2016-06-24 15:02 ` David Craven [this message]
2016-06-24 19:21 ` David Craven
2016-06-26 13:39 ` Ludovic Courtès
[not found] ` <CAL1_immwYLepNEKcyYTOa6Ghhe4yvX5ymFdbsSqtrVUXCUghAQ@mail.gmail.com>
2016-06-26 22:13 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1_im=HWS6ApruxWiv2xVcQ7VpERcLn9=2DxbyQMGFeB2YJWQ@mail.gmail.com' \
--to=david@craven.ch \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.