From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Craven <david@craven.ch>
Subject: Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.
Date: Tue, 2 Aug 2016 13:57:25 +0200
Message-ID: <CAL1_im=0x1=4hVHT_WxGxCpBsV+tk=1hKhd2pHgJzS8BDD3JZw@mail.gmail.com>
References: <20160801181342.16203-1-david@craven.ch>
	<20160801181342.16203-9-david@craven.ch>
	<20160801195700.GD6728@solar>
	<CAL1_imkVf_BKQ1-rdNnzZDAZ46LZyNBB9dg32E1iViySe4rNYA@mail.gmail.com>
	<20160801211739.GA6958@solar>
	<CAL1_im=TRrOifGKjyVhipksVabcz5iGegDpPvEq-e1wS6gzJFw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50600)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bUYKB-0006lX-QI
	for guix-devel@gnu.org; Tue, 02 Aug 2016 07:57:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bUYK8-0000V1-NP
	for guix-devel@gnu.org; Tue, 02 Aug 2016 07:57:31 -0400
Received: from mail-vk0-x241.google.com ([2607:f8b0:400c:c05::241]:33030)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bUYK7-0000TZ-HS
	for guix-devel@gnu.org; Tue, 02 Aug 2016 07:57:28 -0400
Received: by mail-vk0-x241.google.com with SMTP id s189so6833922vkh.0
	for <guix-devel@gnu.org>; Tue, 02 Aug 2016 04:57:26 -0700 (PDT)
In-Reply-To: <CAL1_im=TRrOifGKjyVhipksVabcz5iGegDpPvEq-e1wS6gzJFw@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Andreas Enge <andreas@enge.fr>, =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>

> Ups I just realized I made a mistake on this commit.

What do you want me to do? not that I make things worse... This is
what I pushed.

commit d26e2b9f306a1170d46f7c860c81840d9d600161
Author: David Craven <david@craven.ch>
Date:   Mon Aug 1 16:39:00 2016 +0200

    gnu: kde-frameworks: Remove kde-frameworks-version.

    * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.
      (kwindowsystem)[version]: Replace kde-frameworks-version with
version string.
      (oxygen-icons)[version]: Replace kde-frameworks-version with
version string.

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 74fbac2..b60d85d 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -27,8 +27,6 @@
   #:use-module (gnu packages qt)
   #:use-module (gnu packages xorg))

-(define kde-frameworks-version "5.21.0")
-
 (define-public extra-cmake-modules
   (package
     (name "extra-cmake-modules")
@@ -57,7 +55,7 @@ common build settings used in software produced by
the KDE community.")
 (define-public kwindowsystem
   (package
     (name "kwindowsystem")
-    (version kde-frameworks-version)
+    (version "5.24.0")
     (source
       (origin
         (method url-fetch)
@@ -95,7 +93,7 @@ lower level classes for interaction with the X
Windowing System.")
 (define-public oxygen-icons
   (package
     (name "oxygen-icons")
-    (version kde-frameworks-version)
+    (version "5.24.0")
     (source
       (origin
         (method url-fetch)