From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Craven <david@craven.ch>
Subject: Re: [PATCH 2/2] services: Add 'cuirass-service'.
Date: Wed, 26 Oct 2016 15:35:56 +0200
Message-ID: <CAL1_im=0K4QFLPzdkBZvbu5cqeP6JQCTfZ3_LNiUZTnYA3Myhg@mail.gmail.com>
References: <20161026130558.31924-1-mthl@gnu.org>
	<20161026130558.31924-3-mthl@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54906)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bzON8-0003hA-Mr
	for guix-devel@gnu.org; Wed, 26 Oct 2016 09:36:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bzON4-0001cc-5y
	for guix-devel@gnu.org; Wed, 26 Oct 2016 09:36:02 -0400
Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:39070)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <david@craven.ch>) id 1bzON4-0001cR-1I
	for guix-devel@gnu.org; Wed, 26 Oct 2016 09:35:58 -0400
Received: by mail-qk0-x22a.google.com with SMTP id i34so5727001qkh.6
	for <guix-devel@gnu.org>; Wed, 26 Oct 2016 06:35:57 -0700 (PDT)
In-Reply-To: <20161026130558.31924-3-mthl@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>

Hi Mathieu,

Do we need to export all of these?

+            cuirass-configuration-cache-directory
+            cuirass-configuration-group
+            cuirass-configuration-interval
+            cuirass-configuration-database
+            cuirass-configuration-specifications
+            cuirass-configuration-use-substitutes?
+            cuirass-configuration-one-shot?
+            %default-cuirass-configuration

Is %default-cuirass-configuration needed?

Looks good to me otherwise.

Thank you.
David