From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp11.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id KILVB1UMNmPDfQAAbAwnHQ
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 29 Sep 2022 23:21:25 +0200
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp11.migadu.com with LMTPS
	id +If/B1UMNmMs0QAA9RJhRA
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 29 Sep 2022 23:21:25 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id BA57F3DD3D
	for <larch@yhetil.org>; Thu, 29 Sep 2022 23:21:24 +0200 (CEST)
Received: from localhost ([::1]:45976 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	id 1oe0yC-0002Bz-0F
	for larch@yhetil.org; Thu, 29 Sep 2022 17:21:24 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:40678)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1oe0xq-0002Bj-PB
 for guix-patches@gnu.org; Thu, 29 Sep 2022 17:21:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:40754)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1oe0xq-0000OH-Gu
 for guix-patches@gnu.org; Thu, 29 Sep 2022 17:21:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1oe0xq-0000wf-BV
 for guix-patches@gnu.org; Thu, 29 Sep 2022 17:21:02 -0400
X-Loop: help-debbugs@gnu.org
Subject: [bug#58162] [PATCH] gnu: Add qdmr
Resent-From: Ryan Tolboom <ryan@using.tech>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Thu, 29 Sep 2022 21:21:02 +0000
Resent-Message-ID: <handler.58162.B58162.16644864363579@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 58162
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: "(" <paren@disroot.org>
Cc: 58162@debbugs.gnu.org
Received: via spool by 58162-submit@debbugs.gnu.org id=B58162.16644864363579
 (code B ref 58162); Thu, 29 Sep 2022 21:21:02 +0000
Received: (at 58162) by debbugs.gnu.org; 29 Sep 2022 21:20:36 +0000
Received: from localhost ([127.0.0.1]:39832 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1oe0xP-0000ve-WB
 for submit@debbugs.gnu.org; Thu, 29 Sep 2022 17:20:36 -0400
Received: from mail-pl1-f169.google.com ([209.85.214.169]:38483)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ryan@using.tech>) id 1oe0xN-0000vG-Bh
 for 58162@debbugs.gnu.org; Thu, 29 Sep 2022 17:20:34 -0400
Received: by mail-pl1-f169.google.com with SMTP id x1so2314290plv.5
 for <58162@debbugs.gnu.org>; Thu, 29 Sep 2022 14:20:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=using-tech.20210112.gappssmtp.com; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date;
 bh=s0AeVhX2xWY901OjoIkF2ckJPvFITe72Cunou4bthVg=;
 b=WQ4tI0T72hL3gKDszx9Xs+tOkr6i67BXDddj9OGu8MTkah+UaNg57egMCWxVYN6nkX
 r7dW5MSsubny8QLRr7voOQGFnnSVZiN2mQhKWDpBgs3r+knsaKC6x1n2AeVbhJSWrZ2s
 D4arS43bfPcwVptfyWx8lftavqS6jSY/RRL9UfIBNCHsVVLGV7USHDvvFRck4HoQriRJ
 VRw2y7j4uwRk/HcyDw+sPL3+0/t2vlj2/6TLBQiBbse94gMsHEz/1KUVyMDpfKuMsgYr
 Wk6YfHTfSanycJWxRmsXWeD8uDWJUCwyslaQFiFtXi9BSnqRgTg0bUpg6osMRimQW4Y9
 M84A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date;
 bh=s0AeVhX2xWY901OjoIkF2ckJPvFITe72Cunou4bthVg=;
 b=qgVsUOmrEJGeV7NlabijnxR6o7DhBSC2d0SmriZVEqI55HZk4OoiakbHLmxiq6Mv76
 uRHfETltzkVgo/iuHrVMVEr3dSKGYVGNlEUg6EiNf/GbBDLfoh7EJAXKblHPpbBEdSys
 dRmEED0tnigmkFGkyatNMXuY+LN3Lk9PDkgJTi3NtjnPijMBdKTRURqZ1RKunFbGNxRy
 i9OLcuyUHWQU9GB/pGkgJ2G1axkEDkHfxoCel8QuEm3ssvt6Jwhwei/2L5DdxuExfOjy
 9AJNpLmknrnerwOdL4IjqG+F6calzOJBe/WBwk5lrMeIqCIAxcccqqlgYplF0DVOfyBj
 rUVA==
X-Gm-Message-State: ACrzQf1McxslCLOkUVibgIIw8f4ZPhDHVIsWVYexw+OSsp1oJAdIHDS3
 Mhj9M7oCE3UdKcUK7myWZU5++v4LBDgRni3BYzxrKA==
X-Google-Smtp-Source: AMsMyM5aql7G8DwAyTlj3J9b+9X2xWXEO8O41Lt5wcgflxi2SBqFNTPrkfUI8NkbgX16dYNRCAaFAstiJzmP/+ktrPo=
X-Received: by 2002:a17:902:d489:b0:178:1ad6:6603 with SMTP id
 c9-20020a170902d48900b001781ad66603mr5359429plg.158.1664486427558; Thu, 29
 Sep 2022 14:20:27 -0700 (PDT)
MIME-Version: 1.0
References: <20220929015726.26821-1-ryan@using.tech>
 <CN92QM27AVYH.25YI0XY5IYDKH@guix-aspire>
In-Reply-To: <CN92QM27AVYH.25YI0XY5IYDKH@guix-aspire>
From: Ryan Tolboom <ryan@using.tech>
Date: Thu, 29 Sep 2022 17:20:16 -0400
Message-ID: <CAKskyJqx8UF0_16Pj3UWbbmBb1kByqyrDq+6=k93Q_ncgYX7qw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1664486484;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:resent-cc:resent-from:resent-sender:
	 resent-message-id:in-reply-to:in-reply-to:references:references:
	 list-id:list-help:list-unsubscribe:list-subscribe:list-post:
	 dkim-signature; bh=s0AeVhX2xWY901OjoIkF2ckJPvFITe72Cunou4bthVg=;
	b=E0UszHEka3u2DTNjSFkp9xo7bpGcIm2llsl3frHcrp+uQUutRWZ0pGFKxvMhERjPcmg7bo
	o5V1Gb9psj77/84zpKDXLxhrRKmkJTViDZP/4cJm4cjacUD0QRm4uU/aOg1Q2MhEmZ2CKi
	mOvWSuVn01i16JaEH1d/JoCbUQ3vFJH2GLFNn9VanYjMp5lwtpD8SvbG3X7N16pQ18PZ3S
	vBz50VdRfeLscjBoqkoBtddu2AOIqqLvXVae34hNKLBHPP7Sdpt3ZERUu2Nl6LZMraMQp7
	43uSapNHZcLZft1KTKyR2ZCqB92ZbofvpBaAqWzyGvGRfRMxJD8/9M1xs1d0vA==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664486484; a=rsa-sha256; cv=none;
	b=oPoET4pVtJ3DpgeUsebBNgPp6z8EJtHtX1GbllgFlTj1jiz8y4UBnSuZ6ncA/sYo5cj3RO
	Q1uqmRd4awAbopuKfTRcZoiei3iSj3bUHngv95tLHZn6atyi/PAwk+ruWJd39z4SCd2nlK
	7Vp2txknBYfiX2phc6jojgUnbfiHruoeOucN4YnlEkU33Kd6pYO9257WfkIenF1c3c18Lb
	zjHS8o8GgNVXt5Cf9CWR4zYxX26uPFLBuC11fFRjmZMk2IKmdJ+lzaVH6rxToZM4wANtqK
	npgTETUfl5CHM3WU3T80JKc/I8p1fJN41RalAk6yDI/agYVq0Bku72u+drJWCw==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=using-tech.20210112.gappssmtp.com header.s=20210112 header.b=WQ4tI0T7;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: 2.66
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=using-tech.20210112.gappssmtp.com header.s=20210112 header.b=WQ4tI0T7;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: BA57F3DD3D
X-Spam-Score: 2.66
X-Migadu-Scanner: scn1.migadu.com
X-TUID: B5pBErDhJ1xW

Hello,

Thank you very much for your comments! I apologize for my brevity, I'm
still trying to work out the whole 'git send-email' workflow so my
patches arrive without comments. I did leave some comments through the
web interface, but I'm not seeing them show up.

I was using the 'Hello World' package example initially:
https://guix.gnu.org/cookbook/en/html_node/A-_0060_0060Hello-World_0027_0027-package.html
Do you think I should submit a patch to move home-page to the correct
place in that example?

Regarding the description, I was on the fence about it. I took it from
the GitHub page for the project and wasn't quite sure if it was too
wordy. Also regarding mentioning services in the description, several
other packages in radio.scm do it as well: rtl-sdr, airspyhf, hackrf,
and rfcat. I actually found it quite useful when setting things up,
does it have to be removed?

Anyway the new patch implements all your changes, which BTW
g-expressions are really neat, with the exception of removing the
service line from the description.

Let me know your thoughts,

Ryan


On Thu, Sep 29, 2022 at 1:51 PM ( <paren@disroot.org> wrote:
>
> Hey!
>
> On Thu Sep 29, 2022 at 2:57 AM BST, Ryan Tolboom wrote:
> > +    (native-inputs (list qttools-5))
> > +    (inputs (list qtbase-5 qtserialport qtlocation yaml-cpp libusb))
>
> Usually inputs and native-inputs come after arguments.
>
> > +    (arguments
> > +     `(#:tests? #f ;No tests
> > +       #:phases (modify-phases %standard-phases
> > +                  (add-after 'unpack 'fix-paths
> > +                    (lambda* (#:key outputs #:allow-other-keys)
> > +                      (substitute* "lib/CMakeLists.txt"
> > +                        (("DESTINATION \"/etc/udev/")
> > +                         (string-append "DESTINATION \""
> > +                                        (assoc-ref outputs "out") "/lib/udev/"))))))))
>
> Try using the new gexp style for arguments:
>
>   (arguments
>    (list #:tests? #f ;no tests
>          #:phases
>          #~(modify-phases %standard-phases
>              (add-after 'unpack 'patch-paths
>                (lambda _
>                  (substitute* "lib/CMakeLists.txt"
>                    (("(DESTINATION \")/etc/udev/" _ directive)
>                     (string-append directive #$output "/lib/udev/"))))))))
>
> > +    (description
> > +     "qdmr is a graphical user interface (GUI) application that allows one to
> > +program several types of DMR radios.  To this end, it aims at being a more
> > +universal codeplug programming software (CPS) compared to the device and even
> > +revision specific CPSs provided by the manufacturers.  The goal of this project
> > +is to provide a single, comfortable, well-documented and platform-independent
> > +CPS for several types of (mainly Chinese) DMR radios.
> > +
> > +To install the qdmr udev rules, you must extend @code{udev-service-type} with this
> > +package.  E.g.: @code{(udev-rules-service 'qdmr qdmr)}")
>
> IMO this is too long and markety :) Also, I don't think you should mention
> services in a package description.
>
> > +    (home-page "https://dm3mat.darc.de/qdmr/")
>
> Home-page usually goes directly before synopsis.
>
>     -- (



-- 
Ryan Tolboom
Using Tech LLC