* Re: 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing test. [not found] ` <E1Y0EQZ-0001VA-GJ@vcs.savannah.gnu.org> @ 2014-12-14 22:54 ` Ludovic Courtès 2014-12-15 8:41 ` Federico Beffa 0 siblings, 1 reply; 4+ messages in thread From: Ludovic Courtès @ 2014-12-14 22:54 UTC (permalink / raw) To: Federico Beffa; +Cc: guix-devel Federico Beffa <beffa@fbengineering.ch> skribis: > + (alist-cons-before > + 'check 'fix-failing-tests > + (lambda _ > + (substitute* (find-files "numpy/linalg/tests" > + "test_regression\\.py") > + (("x = np.eye(1000, 66)") > + "x = np.eye(10, 66)"))) Could you add a comment here explaining that this is reducing the input matrix size (?) and why it matters? Otherwise it may seem a bit too magical. :-) Also, this kind of change would be a good candidate for ‘snippet’, because it’s a “static” change. Thanks, Ludo’. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing test. 2014-12-14 22:54 ` 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing test Ludovic Courtès @ 2014-12-15 8:41 ` Federico Beffa 2014-12-15 12:33 ` Federico Beffa 0 siblings, 1 reply; 4+ messages in thread From: Federico Beffa @ 2014-12-15 8:41 UTC (permalink / raw) To: Ludovic Courtès; +Cc: Guix-devel On Sun, Dec 14, 2014 at 11:54 PM, Ludovic Courtès <ludo@gnu.org> wrote: > Federico Beffa <beffa@fbengineering.ch> skribis: > >> + (alist-cons-before >> + 'check 'fix-failing-tests >> + (lambda _ >> + (substitute* (find-files "numpy/linalg/tests" >> + "test_regression\\.py") >> + (("x = np.eye(1000, 66)") >> + "x = np.eye(10, 66)"))) > > Could you add a comment here explaining that this is reducing the input > matrix size (?) and why it matters? Otherwise it may seem a bit too > magical. :-) > > Also, this kind of change would be a good candidate for ‘snippet’, > because it’s a “static” change. OK, I need to look into those :-) Actually the test is still failing and I do not understand why on hydra it is failing while on my machine (x86_64) it passes with both python versions. So, at least for the moment, I would propose to remove the above phase and disable the tests. WDYT? Fede ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing test. 2014-12-15 8:41 ` Federico Beffa @ 2014-12-15 12:33 ` Federico Beffa 2014-12-15 17:11 ` Ludovic Courtès 0 siblings, 1 reply; 4+ messages in thread From: Federico Beffa @ 2014-12-15 12:33 UTC (permalink / raw) To: Ludovic Courtès; +Cc: Guix-devel On Mon, Dec 15, 2014 at 9:41 AM, Federico Beffa <beffa@ieee.org> wrote: > On Sun, Dec 14, 2014 at 11:54 PM, Ludovic Courtès <ludo@gnu.org> wrote: >> Federico Beffa <beffa@fbengineering.ch> skribis: >> >>> + (alist-cons-before >>> + 'check 'fix-failing-tests >>> + (lambda _ >>> + (substitute* (find-files "numpy/linalg/tests" >>> + "test_regression\\.py") >>> + (("x = np.eye(1000, 66)") >>> + "x = np.eye(10, 66)"))) >> >> Could you add a comment here explaining that this is reducing the input >> matrix size (?) and why it matters? Otherwise it may seem a bit too >> magical. :-) >> >> Also, this kind of change would be a good candidate for ‘snippet’, >> because it’s a “static” change. > > OK, I need to look into those :-) > > Actually the test is still failing and I do not understand why on > hydra it is failing while on my machine (x86_64) it passes with both > python versions. So, at least for the moment, I would propose to > remove the above phase and disable the tests. > > WDYT? One more thing: the function causing the test to fail is implemented making use of ATLAS. However, the log does not show ATLAS being built before numpy (as I would expect given the #:substitutable? #f argument). If the machines to which hydra distributes the jobs are not homogeneous, then it could be that the used ATLAS is not working properly (maybe different ISA extensions?). If that is the case, then why is the #:substitutable argument not honored? What machines is the build farm made of? Do they all have the same version of OS and kernel? Regards, Fede ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing test. 2014-12-15 12:33 ` Federico Beffa @ 2014-12-15 17:11 ` Ludovic Courtès 0 siblings, 0 replies; 4+ messages in thread From: Ludovic Courtès @ 2014-12-15 17:11 UTC (permalink / raw) To: Federico Beffa; +Cc: Guix-devel Federico Beffa <beffa@ieee.org> skribis: > One more thing: the function causing the test to fail is implemented > making use of ATLAS. However, the log does not show ATLAS being built > before numpy (as I would expect given the #:substitutable? #f > argument). If the machines to which hydra distributes the jobs are not > homogeneous, then it could be that the used ATLAS is not working > properly (maybe different ISA extensions?). If that is the case, then > why is the #:substitutable argument not honored? I *think* that what happens, is that #:substitutable? also prevents offloading (because of <http://bugs.gnu.org/18747>.) So, since hydra.gnu.org currently runs the guix-daemon with --max-jobs=1, it probably ends up building ATLAS locally (this machine is a Quad-Core AMD Opteron(tm) Processor 2374 HE, but actually a VM.) However, numpy itself does get offloaded, so ATLAS from the step above ends up being transferred to whatever machine is building numpy, which could explain the problem. I’m not sure exactly what to do. Perhaps we should just exclude ATLAS and whatever refers to it from Hydra? > What machines is the build farm made of? Do they all have the same > version of OS and kernel? No, they’re different. The CPU and kernel are the only “impurities” that leak through the build environment though. It rarely matters, but ATLAS is clearly a case where it does make a difference. Thanks, Ludo’. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-15 17:12 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20141214190158.5716.92499@vcs.savannah.gnu.org> [not found] ` <E1Y0EQZ-0001VA-GJ@vcs.savannah.gnu.org> 2014-12-14 22:54 ` 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing test Ludovic Courtès 2014-12-15 8:41 ` Federico Beffa 2014-12-15 12:33 ` Federico Beffa 2014-12-15 17:11 ` Ludovic Courtès
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/guix.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.