all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Federico Beffa <beffa@ieee.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing test.
Date: Mon, 15 Dec 2014 13:33:45 +0100	[thread overview]
Message-ID: <CAKrPhPPwmC=h5xS02r6urcm-nAAeH+3mfb7NjGMf35f=k9Ar4A@mail.gmail.com> (raw)
In-Reply-To: <CAKrPhPP_3w3fpwmZzk6E610KDxXfM+vHuTTscX2tpqDeNXQ+gQ@mail.gmail.com>

On Mon, Dec 15, 2014 at 9:41 AM, Federico Beffa <beffa@ieee.org> wrote:
> On Sun, Dec 14, 2014 at 11:54 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>> Federico Beffa <beffa@fbengineering.ch> skribis:
>>
>>> +        (alist-cons-before
>>> +         'check 'fix-failing-tests
>>> +         (lambda _
>>> +           (substitute* (find-files "numpy/linalg/tests"
>>> +                                    "test_regression\\.py")
>>> +             (("x = np.eye(1000, 66)")
>>> +              "x = np.eye(10, 66)")))
>>
>> Could you add a comment here explaining that this is reducing the input
>> matrix size (?) and why it matters?  Otherwise it may seem a bit too
>> magical.  :-)
>>
>> Also, this kind of change would be a good candidate for ‘snippet’,
>> because it’s a “static” change.
>
> OK, I need to look into those :-)
>
> Actually the test is still failing and I do not understand why on
> hydra it is failing while on my machine (x86_64) it passes with both
> python versions.  So, at least for the moment, I would propose to
> remove the above phase and disable the tests.
>
> WDYT?

One more thing: the function causing the test to fail is implemented
making use of ATLAS. However, the log does not show ATLAS being built
before numpy (as I would expect given the #:substitutable? #f
argument). If the machines to which hydra distributes the jobs are not
homogeneous, then it could be that the used ATLAS is not working
properly (maybe different ISA extensions?). If that is the case, then
why is the #:substitutable argument not honored?

What machines is the build farm made of? Do they all have the same
version of OS and kernel?

Regards,
Fede

  reply	other threads:[~2014-12-15 12:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20141214190158.5716.92499@vcs.savannah.gnu.org>
     [not found] ` <E1Y0EQZ-0001VA-GJ@vcs.savannah.gnu.org>
2014-12-14 22:54   ` 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing test Ludovic Courtès
2014-12-15  8:41     ` Federico Beffa
2014-12-15 12:33       ` Federico Beffa [this message]
2014-12-15 17:11         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKrPhPPwmC=h5xS02r6urcm-nAAeH+3mfb7NjGMf35f=k9Ar4A@mail.gmail.com' \
    --to=beffa@ieee.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.