From: Federico Beffa <beffa@ieee.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/4] gnu: Add xcffib
Date: Wed, 17 Dec 2014 17:57:56 +0100 [thread overview]
Message-ID: <CAKrPhPPL8iUZ_v+F4V2ZhoSAwR+ZmbMxg0-BAp8bmD2vYaa=9w@mail.gmail.com> (raw)
In-Reply-To: <87ppbkeeyh.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
On Mon, Dec 15, 2014 at 11:16 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> Federico Beffa <beffa@ieee.org> skribis:
>
>> From f4187d31f95e3a65947d77bf267115906ed3816b Mon Sep 17 00:00:00 2001
>> From: Federico Beffa <beffa@fbengineering.ch>
>> Date: Wed, 10 Dec 2014 20:36:58 +0100
>> Subject: [PATCH 2/4] gnu: Add xcffib
>>
>> * gnu/packages/python.scm (python-xcffib, python2-xcffib): New variables.
>
> [...]
>
>> + (propagated-inputs
>> + `(("python-cffi" ,python-cffi)))
>
> Please add a comment saying why this is propagated.
>
>> + (synopsis "XCB Python binding")
>
> “bindings” (plural)
>
>> + (description
>> + "A drop in replacement for xpyb, an XCB python binding.")
>
> “drop-in”, “Python”, “bindings”.
>
> Could you expound the description a little bit?
Please find attached an updated patch. Regarding the description: I've
tried to expand it a little, but, to be honest, I do not know much
about this package. I copied the description from the web site. I only
packaged it because it is used by other packages I'm interested in :-)
Regards,
Fede
[-- Attachment #2: 0002-gnu-Add-xcffib.patch --]
[-- Type: text/x-patch, Size: 2378 bytes --]
From 2b7df0f474c1e57eb31a81693500b686d177f3a1 Mon Sep 17 00:00:00 2001
From: Federico Beffa <beffa@fbengineering.ch>
Date: Wed, 10 Dec 2014 20:36:58 +0100
Subject: [PATCH 2/4] gnu: Add xcffib
* gnu/packages/python.scm (python-xcffib, python2-xcffib): New variables.
---
gnu/packages/python.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 67effe7..c2657f2 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -50,6 +50,7 @@
#:use-module (gnu packages fontutils)
#:use-module (gnu packages which)
#:use-module (gnu packages perl)
+ #:use-module (gnu packages xorg)
#:use-module (guix packages)
#:use-module (guix download)
#:use-module (guix git-download)
@@ -2541,3 +2542,45 @@ a front-end for C compilers or analysis tools.")
(define-public python2-cffi
(package-with-python2 python-cffi))
+
+(define-public python-xcffib
+ (package
+ (name "python-xcffib")
+ (version "0.1.9")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://pypi.python.org/packages/source/x/"
+ "xcffib/xcffib-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0655hzxv57h1a9ja9kwp0ichbkhf3djw32k33d66xp0q37dq2y81"))))
+ (build-system python-build-system)
+ (inputs
+ `(("libxcb" ,libxcb)
+ ("python-six" ,python-six)))
+ (native-inputs
+ `(("python-setuptools" ,python-setuptools)))
+ (propagated-inputs
+ `(("python-cffi" ,python-cffi))) ; used at run time
+ (arguments
+ `(#:phases
+ (alist-cons-after
+ 'install 'install-doc
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((doc (string-append (assoc-ref outputs "out") "/share"
+ "/doc/" ,name "-" ,version)))
+ (mkdir-p doc)
+ (copy-file "README.md"
+ (string-append doc "/README.md"))))
+ %standard-phases)))
+ (home-page "https://github.com/tych0/xcffib")
+ (synopsis "XCB Python bindings")
+ (description
+ "Xcffib is a replacement for xpyb, an XCB Python bindings. It adds
+support for Python 3 and PyPy. It is based on cffi.")
+ (license expat)))
+
+(define-public python2-xcffib
+ (package-with-python2 python-xcffib))
+
--
1.8.4
next prev parent reply other threads:[~2014-12-17 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 19:40 [PATCH 2/4] gnu: Add xcffib Federico Beffa
2014-12-15 22:16 ` Ludovic Courtès
2014-12-16 17:17 ` Federico Beffa
2014-12-17 9:01 ` Ludovic Courtès
2014-12-17 16:57 ` Federico Beffa [this message]
2014-12-17 20:28 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKrPhPPL8iUZ_v+F4V2ZhoSAwR+ZmbMxg0-BAp8bmD2vYaa=9w@mail.gmail.com' \
--to=beffa@ieee.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.