From mboxrd@z Thu Jan 1 00:00:00 1970 From: Federico Beffa Subject: Re: [PATCH 3/5] build: Add 'emacs-build-system' Date: Thu, 25 Jun 2015 20:39:55 +0200 Message-ID: References: <87twu06bhk.fsf@gmail.com> <87si9jsjyj.fsf@gmail.com> <87pp4khuga.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8C44-0007Yw-U9 for guix-devel@gnu.org; Thu, 25 Jun 2015 14:39:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8C43-0008LU-Uq for guix-devel@gnu.org; Thu, 25 Jun 2015 14:39:56 -0400 In-Reply-To: <87pp4khuga.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: Guix-devel , Alex Kost On Thu, Jun 25, 2015 at 1:57 PM, Ludovic Court=C3=A8s wrote: > Federico Beffa skribis: > >> On Mon, Jun 22, 2015 at 9:40 PM, Thompson, David >> wrote: >>> On Mon, Jun 22, 2015 at 3:33 PM, Federico Beffa wrote: >>>> >>>> But, my question was NOT: how can I see white spaces. Rather: is there >>>> a Guix coding style "rule" which states that white spaces there are >>>> undesired. >>>> >>>> I personally prefer to have them, because then, if I use M-up/down, I >>>> move to the beginning/end of a whole top-level block, without stopping >>>> at internal points and that's what I want most of the time. >>>> >>>> So, these spaces are not just coding artifacts, but have some use. >>> >>> There should be *no* trailing whitespace in submitted patches, and we >>> should add a note about it to our contribution guidelines if it's not >>> already there. > > +1 > >> OK, I will delete those spaces then. But, I'm curious about the >> rationale for such a rule. > > It=E2=80=99s mostly that no-trailing-whitespace is a simple canonical for= m. > Having everyone follow it makes sure we don=E2=80=99t run into annoying p= atch > conflicts due to whitespace, nor =E2=80=9Cnoisy patches=E2=80=9D that rem= ove trailing > spaces here and there. Makes sense. Thanks for the explanation. Fede