From: Federico Beffa <beffa@ieee.org>
To: Alex Kost <alezost@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 1/2] gnu: Add the X color name database file.
Date: Fri, 13 May 2016 20:50:28 +0200 [thread overview]
Message-ID: <CAKrPhPOd=08U6cwz1CpLh8D3eOpXF=yf9jyYKmfuZL0WZCgDtg@mail.gmail.com> (raw)
In-Reply-To: <87zirt7s45.fsf@gmail.com>
On Fri, May 13, 2016 at 8:03 PM, Alex Kost <alezost@gmail.com> wrote:
> Federico Beffa (2016-05-13 19:51 +0300) wrote:
>
>> This package provides the X 'rgb.txt' color name database. It is not
>> needed anymore by Xorg, but some packages (e.g. netpbm) still rely on
>> it.
>
> Great, thanks! This package even has a binary (showrgb); I never knew
> this. I have only a couple of nit-pickings that can be ignored.
>
>> From be30973db650aba34323900806adb30d2fe74b1d Mon Sep 17 00:00:00 2001
>> From: Federico Beffa <beffa@fbengineering.ch>
>> Date: Fri, 13 May 2016 09:22:44 +0200
>> Subject: [PATCH 1/2] gnu: Add the X color name database file.
>>
>> * gnu/packages/xorg.scm (xorg-rgb): New variable.
>> ---
>> gnu/packages/xorg.scm | 25 ++++++++++++++++++++++++-
>> 1 file changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
>> index fd933e3..9323286 100644
>> --- a/gnu/packages/xorg.scm
>> +++ b/gnu/packages/xorg.scm
>> @@ -4281,7 +4281,30 @@ Various information is displayed depending on which options are selected.")
>> formatted dump file, such as produced by xwd.")
>> (license license:x11)))
>>
>> -
>> +(define-public xorg-rgb
>> + (package
>> + (name "xorg-rgb")
>> + (version "1.0.6")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "mirror://xorg/individual/app/rgb-"
>> + version
>> + ".tar.bz2"))
>
> It's your choice of course, but I would put version and ".tar.bz2" on a
> single line; I find it more good-looking in such cases.
I like better what you propose, but I've followed the style of all the
other definitions in the same file for consistency.
>
>> + (sha256
>> + (base32
>> + "1c76zcjs39ljil6f6jpx1x17c8fnvwazz7zvl3vbjfcrlmm7rjmv"))))
>> + (build-system gnu-build-system)
>> + (inputs
>> + `(("xproto" ,xproto)))
>> + (native-inputs
>> + `(("pkg-config" ,pkg-config)))
>
> These inputs are indented too much. I guess you made this package
> definition by copying 'xwud' (the previous one in "xorg.scm" file) and
> modifying it. Make sure to reindent this xorg-rgb package sexp.
> Otherwise looks good to me, thanks!
>
Fixed.
Fede
prev parent reply other threads:[~2016-05-13 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 16:51 [PATCH 1/2] gnu: Add the X color name database file Federico Beffa
2016-05-13 18:03 ` Alex Kost
2016-05-13 18:50 ` Federico Beffa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKrPhPOd=08U6cwz1CpLh8D3eOpXF=yf9jyYKmfuZL0WZCgDtg@mail.gmail.com' \
--to=beffa@ieee.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.