From mboxrd@z Thu Jan 1 00:00:00 1970 From: Federico Beffa Subject: Re: [PATCH 3/5] build: Add 'emacs-build-system' Date: Mon, 22 Jun 2015 21:33:23 +0200 Message-ID: References: <87twu06bhk.fsf@gmail.com> <87si9jsjyj.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z77TB-0001yc-2L for guix-devel@gnu.org; Mon, 22 Jun 2015 15:33:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z77TA-0007Xi-6B for guix-devel@gnu.org; Mon, 22 Jun 2015 15:33:25 -0400 Received: from mail-ig0-x22a.google.com ([2607:f8b0:4001:c05::22a]:37660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z77TA-0007Xb-1X for guix-devel@gnu.org; Mon, 22 Jun 2015 15:33:24 -0400 Received: by igblr2 with SMTP id lr2so60670361igb.0 for ; Mon, 22 Jun 2015 12:33:23 -0700 (PDT) In-Reply-To: <87si9jsjyj.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: Guix-devel On Mon, Jun 22, 2015 at 7:59 PM, Alex Kost wrote: > Federico Beffa (2015-06-22 11:51 +0300) wrote: > >> On Sun, Jun 21, 2015 at 10:40 PM, Alex Kost wrote: >>>> new file mode 100644 >>>> index 0000000..da2b594 >>>> --- /dev/null >>>> +++ b/guix/build-system/emacs.scm >>> [...] >>>> + #:tests? ,tests? >>>> + #:phases ,phases >>>> + #:outputs %outputs >>>> + #:search-paths ',(map search-path-specification->sexp >>>> + search-paths) >>>> + #:inputs %build-inputs))) >>>> + >>> spaces on this line ^ >> >> Hi, thanks for the review! >> >> This and other spaces that you indicate as "extra", are included by >> Emacs by pressing TAB. This is because, as an example, the above >> snippet finishes an internal define form and not a top-level form. > > Then don't press TAB on an empty line if you are not going to write > something there :-) > >> I'm following the Emacs behavior. Is there a convention to suppress >> all spaces (in spite of what Emacs does)? > > Well, these trailing spaces are artifacts of (inaccurate) coding. Emacs > can't read user's mind to decide if the spaces are redundant or > intended. No need to read the mind... you just look if there are characters other than white spaces (and possibly TABs) between newlines :-) But, my question was NOT: how can I see white spaces. Rather: is there a Guix coding style "rule" which states that white spaces there are undesired. I personally prefer to have them, because then, if I use M-up/down, I move to the beginning/end of a whole top-level block, without stopping at internal points and that's what I want most of the time. So, these spaces are not just coding artifacts, but have some use. Fede