Re: [PATCH 3/5] build: Add 'emacs-build-system'

[Federico Beffa <beffa@ieee.org>]

On Mon, Jun 22, 2015 at 7:59 PM, Alex Kost <alezost@gmail.com> wrote:
> Federico Beffa (2015-06-22 11:51 +0300) wrote:
>
>> On Sun, Jun 21, 2015 at 10:40 PM, Alex Kost <alezost@gmail.com> wrote:
>>>> new file mode 100644
>>>> index 0000000..da2b594
>>>> --- /dev/null
>>>> +++ b/guix/build-system/emacs.scm
>>> [...]
>>>> +                    #:tests? ,tests?
>>>> +                    #:phases ,phases
>>>> +                    #:outputs %outputs
>>>> +                    #:search-paths ',(map search-path-specification->sexp
>>>> +                                          search-paths)
>>>> +                    #:inputs %build-inputs)))
>>>> +
>>> spaces on this line ^
>>
>> Hi, thanks for the review!
>>
>> This and other spaces that you indicate as "extra", are included by
>> Emacs by pressing TAB. This is because, as an example, the above
>> snippet finishes an internal define form and not a top-level form.
>
> Then don't press TAB on an empty line if you are not going to write
> something there :-)
>
>> I'm following the Emacs behavior. Is there a convention to suppress
>> all spaces (in spite of what Emacs does)?
>
> Well, these trailing spaces are artifacts of (inaccurate) coding.  Emacs
> can't read user's mind to decide if the spaces are redundant or
> intended.

No need to read the mind... you just look if there are characters
other than white spaces (and possibly TABs) between newlines :-)

But, my question was NOT: how can I see white spaces. Rather: is there
a Guix coding style "rule" which states that white spaces there are
undesired.

I personally prefer to have them, because then, if I use M-up/down, I
move to the beginning/end of a whole top-level block, without stopping
at internal points and that's what I want most of the time.

So, these spaces are not just coding artifacts, but have some use.

Fede