From mboxrd@z Thu Jan  1 00:00:00 1970
From: Federico Beffa <beffa@ieee.org>
Subject: Re: [PATCH] gnu: Add pyparsing.
Date: Tue, 25 Nov 2014 18:51:15 +0100
Message-ID: <CAKrPhPOEKgnUKgq8xgjiefFaASDZBM+k8SfqhbQFt1eo3Zd=hQ@mail.gmail.com>
References: <CAKrPhPN_RqK2ViC_d8mudL3TuRRXS0DUrMgSmUmDidW8zt+tOw@mail.gmail.com>
	<87a93ftcv2.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35328)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1XtKGo-0008Ry-R0
	for guix-devel@gnu.org; Tue, 25 Nov 2014 12:51:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1XtKGj-0000c9-Ak
	for guix-devel@gnu.org; Tue, 25 Nov 2014 12:51:22 -0500
Received: from mail-lb0-x22c.google.com ([2a00:1450:4010:c04::22c]:59228)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1XtKGj-0000bq-2g
	for guix-devel@gnu.org; Tue, 25 Nov 2014 12:51:17 -0500
Received: by mail-lb0-f172.google.com with SMTP id u10so1014167lbd.31
	for <guix-devel@gnu.org>; Tue, 25 Nov 2014 09:51:15 -0800 (PST)
In-Reply-To: <87a93ftcv2.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>

Cyril Roelandt <tipecaml@gmail.com> writes:

>
> Maybe you could add the PyPI mirror here.
>

I'm not sure I understand. Do you mean replace or really add? A second
uri field? Could you give an example? The sourceforge download site is
the one mentioned on the homepage.

>
> There is a "unitTests.py" that can be run manually, if I'm not mistaken.
> Maybe you could replace the check phase ?
>

I do not think so.  I do not see any reference to tests in the README
and other source files and I can't find a file called "unitTests.py".

>
> I trust you on the doc thing :) Is it something that could somehow be
> part of the python build system?
>

I'm not a python expert :-) From the few packages that I prepared
lately, I have the impression that each python library does something
different with the documentation.

>
> Do not start the synopsis by "a". You may want to run "guix lint" on
> your package to find such issues.
>

Ooops, forgot to run that.

Thanks for the review,
Fede