From mboxrd@z Thu Jan 1 00:00:00 1970 From: Federico Beffa Subject: Re: [PATCH 4/6] gnu: Add emacs-constants. Date: Sat, 9 Jan 2016 11:42:52 +0100 Message-ID: References: <87vb77k7bv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHqz0-0004RS-0b for guix-devel@gnu.org; Sat, 09 Jan 2016 05:42:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHqyy-00069g-Om for guix-devel@gnu.org; Sat, 09 Jan 2016 05:42:53 -0500 In-Reply-To: <87vb77k7bv.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: Guix-devel On Tue, Jan 5, 2016 at 11:08 PM, Ludovic Court=C3=A8s wrote: > Federico Beffa skribis: >> +(define* (uncompressed-file-fetch url hash-algo hash >> + #:optional name >> + #:key (system (%current-system)) >> + (guile (default-guile))) >> + (mlet %store-monad ((drv (url-fetch url hash-algo hash name >> + #:system system >> + #:guile guile))) >> + (gexp->derivation (or name (basename url)) >> + #~(begin >> + (mkdir #$output) >> + (setenv "PATH" >> + (string-append #$gzip "/bin")) >> + (chdir #$output) >> + (copy-file #$drv (basename #$url)))))) > > The dependency on gzip can be removed. > > Also, the second derivation is okay, but kind of wasteful: it only > serves to move the file in a directory so the patch-application logic > can work. Of course it would be better if the patch logic would recognize this case. Then we wouldn't need the above procedure. > > However, I=E2=80=99m unsure the patch in question really belongs here. A= fter > all, there=E2=80=99s just one file, and additionally it=E2=80=99s called = =E2=80=98constants.el=E2=80=99! > ;-) I'm not sure I understand what you are trying to say. Could you please be more explicit. > >> diff --git a/gnu/packages/patches/emacs-constants-lisp-like.patch b/gnu/= packages/patches/emacs-constants-lisp-like.patch >> new file mode 100644 >> index 0000000..5ec37f3 >> --- /dev/null >> +++ b/gnu/packages/patches/emacs-constants-lisp-like.patch >> @@ -0,0 +1,81 @@ >> +Add Scheme support > > This is too terse, and I feel like the patch really does upstream work. > > It seems that the file has a new home (or is it just a mirror?) at > > https://github.com/emacsmirror/constants/blob/master/constants.el > > Is the patch yours? If yes, could you find an upstream to submit it > too? If there=E2=80=99s no such thing, you could always become the upstr= eam. > ;-) The above URL is just a snapshot of the file. No activity whatsoever. Yes, the patch is mine, following suggestions in the file itself. It is to make the package usable with lisp like syntax so that you don't get e.g.: c =3D 2.99...e8 when you insert a constant in a scheme/lisp buffer. Isn't this project fanatic about scheme? ;-) I don't think there is an upstream. In any case I have no intention of becoming one. Thanks for the review. Regards, Fede