From mboxrd@z Thu Jan 1 00:00:00 1970 From: Federico Beffa Subject: Re: [PATCH 2/2] gnu: Add emacs-org-trello. Date: Fri, 28 Oct 2016 18:21:32 +0200 Message-ID: References: <87oa2887b1.fsf@gnu.org> <87bmy8glwz.fsf@elephly.net> <877f8udwha.fsf@gnu.org> <87shrhg9yb.fsf@elephly.net> <87insdmz3f.fsf@gmail.com> <87mvhpfx22.fsf@elephly.net> <87lgx8ddne.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c09uS-0001vV-Kj for guix-devel@gnu.org; Fri, 28 Oct 2016 12:21:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c09uR-00070W-Ru for guix-devel@gnu.org; Fri, 28 Oct 2016 12:21:36 -0400 In-Reply-To: <87lgx8ddne.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: Guix-devel On Fri, Oct 28, 2016 at 11:30 AM, Alex Kost wrote: > Ricardo Wurmus (2016-10-27 20:48 +0200) wrote: > >> Alex Kost writes: >> >>>> @Alex: could you please confirm this? Should these inputs be mentione= d >>>> at all? If so, is it sufficient to add them to native-inputs? >>> >>> As for me, I don't see a reason to add these additional inputs, >>> emacs-build-system will not run tests anyway. >> >> Thank you for clarifying. >> >> Is there a reason why we don=E2=80=99t run the tests? We do this by def= ault for >> all other packages. > > How can it be done? There is no common way for emacs packages to > perform tests: only some packages have Makefile (with "check" phase), > and it would be a really good luck if "make check" as is succeeded for > them. Usually such projects use Cask to run tests or even some custom > scripts. They may use just "ert" or "ert-running" package (or maybe > something else). > > After all, I think that adding a 'check' phase to emacs-build-system is > not worth an effort: there would be too much manual interventions in > package recipes to make tests work for different emacs packages. You said it all! Fede