From mboxrd@z Thu Jan 1 00:00:00 1970 From: Federico Beffa Subject: Re: [PATCH 3/4] gnu: libcanberra: Add propagated-input. Date: Sun, 21 Dec 2014 16:33:51 +0100 Message-ID: References: <87oaqxqn2h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y2iW1-0003S0-BW for guix-devel@gnu.org; Sun, 21 Dec 2014 10:33:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y2iW0-0002VY-6T for guix-devel@gnu.org; Sun, 21 Dec 2014 10:33:53 -0500 In-Reply-To: <87oaqxqn2h.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: Guix-devel On Sun, Dec 21, 2014 at 12:06 PM, Ludovic Court=C3=A8s wrote= : > Federico Beffa skribis: > >> I propose to make sound-theme-freedesktop a propagated input of >> libcanberra. This is because, according to the XDG sound theme >> specification, those event sounds should always be present and used as >> fall-back in case other sounds are not present. >> >> http://www.freedesktop.org/wiki/Specifications/sound-theme-spec/ > > That=E2=80=99s not the right fix, I think. For instance, if Evince is in= stalled > in a profile, but libcanberra itself is not in the profile, then the > sound theme is not pulled and ends up not being used. > > Would it be possible, instead, to patch libcanberra to refer to the > sound-theme directory as its fallback? The location of the sound theme is specified, among other things, by the variable XDG_DATA_DIRS. So, if an application makes use of the glib-or-gtk-build-system and has the sounds as inputs, then it should find them. I don't think we need to patch libcanberra in any way. With my suggestion I was trying to avoid having to specify sound-theme-freedesktop in addition to libcanberra in every gtk application (as, e.g., evince). If we make libcanberra a propagated-input of applications like evince, then they would automatically know the location of the sounds (by the inheritance of propagated inputs). > > Thanks, > Ludo=E2=80=99.