From: Federico Beffa <beffa@ieee.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/2] gnu: Add gnome-themes-standard.
Date: Tue, 4 Nov 2014 12:15:15 +0100 [thread overview]
Message-ID: <CAKrPhPMi1rrQ7r0PzZHkmkq5vXdtGs953O8Ke6SjXd67iV+0vw@mail.gmail.com> (raw)
In-Reply-To: <87sii07x41.fsf@gnu.org>
On Mon, Nov 3, 2014 at 11:11 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>> +;; The version of this package should be the same as the version of
>> +;; gnome-desktop.
>> +(define-public gnome-themes-standard
>> + (package
>> + (name "gnome-themes-standard")
>> + (version "3.10.0")
>
> Please use (version (package-version gnome-desktop)) here, and put the
> comment just above it.
I thought about this, but did not do it because, if the version
changes, then you also need to change the hash. So, if someone
changes gnome-desktop without bothering about gnome-themes-standard,
then the latter would break. By keeping a separate string the package
would still build, but maybe with a slight odd look. WDYT?
Regards,
Fede
next prev parent reply other threads:[~2014-11-04 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 17:21 [PATCH 2/2] gnu: Add gnome-themes-standard Federico Beffa
2014-11-03 22:11 ` Ludovic Courtès
2014-11-04 11:15 ` Federico Beffa [this message]
2014-11-04 16:52 ` Ludovic Courtès
2014-11-04 17:21 ` Federico Beffa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKrPhPMi1rrQ7r0PzZHkmkq5vXdtGs953O8Ke6SjXd67iV+0vw@mail.gmail.com \
--to=beffa@ieee.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.