From mboxrd@z Thu Jan  1 00:00:00 1970
From: Federico Beffa <beffa@ieee.org>
Subject: Re: [PATCH 06/15] gnu: Add chez-irregex.
Date: Mon, 17 Oct 2016 18:19:46 +0200
Message-ID: <CAKrPhPMcK1yf8MVKgUcyjs7UD_iX2uDCeOTiBYP+Dy2azgpFiQ@mail.gmail.com>
References: <CAKrPhPOq5LjN-5oMLp04HoKUBE=fPmNpBmw3VgL6Md77QFbXEg@mail.gmail.com>
	<87bmyj9gys.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56587)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1bwAdi-0001xB-1e
	for guix-devel@gnu.org; Mon, 17 Oct 2016 12:19:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1bwAdh-0006mC-44
	for guix-devel@gnu.org; Mon, 17 Oct 2016 12:19:50 -0400
In-Reply-To: <87bmyj9gys.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>

On Mon, Oct 17, 2016 at 4:40 PM, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
> Federico Beffa <beffa@ieee.org> skribis:
>
>> From 4293c55d921d82c0542907024a1b51abea32b6dc Mon Sep 17 00:00:00 2001
>> From: Federico Beffa <beffa@fbengineering.ch>
>> Date: Sun, 16 Oct 2016 16:10:31 +0200
>> Subject: [PATCH 06/15] gnu: Add chez-irregex.
>>
>> * gnu/packages/chez.scm (chez-irregex): New variable.
>
> [...]
>
>> +       (uri (string-append
>> +             "https://github.com/fedeinthemix/chez-irregex/archive"
>> +             "/v" version ".tar.gz"))
>
> Wouldn=E2=80=99t it work to use the upstream Irregex as done in the
> =E2=80=98guile-irregex=E2=80=99 package?

The original source includes a module definition for Guile, but not
one for R6RS Scheme. This package wraps the original code in an R6RS
library definition and adds a file to make it easy to run the test
suite.

>
> Otherwise LGTM.
>
> Ludo=E2=80=99.