From mboxrd@z Thu Jan  1 00:00:00 1970
From: Federico Beffa <beffa@ieee.org>
Subject: Re: [PATCH 1/4] guix: build/glib-or-gtk-build-system: Add support for
	GIO and XDG theming.
Date: Sun, 21 Dec 2014 10:41:03 +0100
Message-ID: <CAKrPhPMNhMmgepevmDDaMfgcu5z8j50f540K_EBXTozn9vOtzA@mail.gmail.com>
References: <CAKrPhPM04Nno35wEVoL1MnrujTpJ2nHBrG9J0RVfgGRBdRvNvA@mail.gmail.com>
	<877fxnhk78.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40306)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1Y2d0c-00027S-LP
	for guix-devel@gnu.org; Sun, 21 Dec 2014 04:41:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1Y2d0b-0004My-LC
	for guix-devel@gnu.org; Sun, 21 Dec 2014 04:41:06 -0500
Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:41229)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1Y2d0b-0004Mq-Dd
	for guix-devel@gnu.org; Sun, 21 Dec 2014 04:41:05 -0500
Received: by mail-lb0-f170.google.com with SMTP id 10so2705318lbg.29
	for <guix-devel@gnu.org>; Sun, 21 Dec 2014 01:41:03 -0800 (PST)
In-Reply-To: <877fxnhk78.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?UTF-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>

On Fri, Dec 19, 2014 at 1:56 PM, =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail=
.com> wrote:
> FYI, every apps will install icons into 'hicolor-icon-theme',
> for it to work, we need regenerated the 'icon-theme.cache'
> by `gtk-update-icon-cache`.

The icon packages that I looked into are generating the cache by
themselves at installation.  In any case, I think we can add a check
similar to one we do for schemas, just in case some icon packages do
not generate the cache.

> We should avoid hardcoding guix-profile or current-system to packages.
> IMO, for those kind of things, a better place would be '/etc/profile'.
>
> And, apps will crash when user has incompatible gio modules, See:
>
>     https://github.com/NixOS/nixpkgs/issues/1357

I agree, keeping the guix-profile out is actually increasing flexibility.

Thanks for the review and the suggestions!
I will update the patch accordingly.

Regards,
Fede