all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Federico Beffa <beffa@ieee.org>
To: 宋文武 <iyzsong@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 1/4] guix: build/glib-or-gtk-build-system: Add support for GIO and XDG theming.
Date: Sun, 21 Dec 2014 10:41:03 +0100	[thread overview]
Message-ID: <CAKrPhPMNhMmgepevmDDaMfgcu5z8j50f540K_EBXTozn9vOtzA@mail.gmail.com> (raw)
In-Reply-To: <877fxnhk78.fsf@gmail.com>

On Fri, Dec 19, 2014 at 1:56 PM, 宋文武 <iyzsong@gmail.com> wrote:
> FYI, every apps will install icons into 'hicolor-icon-theme',
> for it to work, we need regenerated the 'icon-theme.cache'
> by `gtk-update-icon-cache`.

The icon packages that I looked into are generating the cache by
themselves at installation.  In any case, I think we can add a check
similar to one we do for schemas, just in case some icon packages do
not generate the cache.

> We should avoid hardcoding guix-profile or current-system to packages.
> IMO, for those kind of things, a better place would be '/etc/profile'.
>
> And, apps will crash when user has incompatible gio modules, See:
>
>     https://github.com/NixOS/nixpkgs/issues/1357

I agree, keeping the guix-profile out is actually increasing flexibility.

Thanks for the review and the suggestions!
I will update the patch accordingly.

Regards,
Fede

  reply	other threads:[~2014-12-21  9:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 21:10 [PATCH 1/4] guix: build/glib-or-gtk-build-system: Add support for GIO and XDG theming Federico Beffa
2014-12-19 12:56 ` 宋文武
2014-12-21  9:41   ` Federico Beffa [this message]
2014-12-21 10:54     ` Ludovic Courtès
2015-01-07 17:27       ` Federico Beffa
2015-01-08 12:39         ` 宋文武
2015-01-08 17:43           ` Federico Beffa
2015-01-08 20:26             ` Ludovic Courtès
2015-01-08 21:46               ` Federico Beffa
2015-01-10 21:08                 ` Ludovic Courtès
2015-01-11  8:25                   ` Federico Beffa
2015-01-11 10:55                     ` Ludovic Courtès
2015-01-12 21:33                     ` Mark H Weaver
2015-01-13  8:18                       ` Federico Beffa
2015-01-09  1:57             ` 宋文武
2015-01-08 20:27           ` Ludovic Courtès
2015-01-09  2:00             ` 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKrPhPMNhMmgepevmDDaMfgcu5z8j50f540K_EBXTozn9vOtzA@mail.gmail.com \
    --to=beffa@ieee.org \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.