* [PATCH 2/2] gnu: Add gnome-themes-standard.
@ 2014-11-02 17:21 Federico Beffa
2014-11-03 22:11 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Federico Beffa @ 2014-11-02 17:21 UTC (permalink / raw
To: Guix-devel
[-- Attachment #1: Type: text/plain, Size: 50 bytes --]
Package for GNOME 3 default theme.
Regards,
Fede
[-- Attachment #2: 0002-gnu-Add-gnome-themes-standard.patch --]
[-- Type: text/x-patch, Size: 2285 bytes --]
From 7439f19c1f2966466da88554478b796c3bfca429 Mon Sep 17 00:00:00 2001
From: Federico Beffa <beffa@fbengineering.ch>
Date: Sun, 2 Nov 2014 18:09:33 +0100
Subject: [PATCH 2/2] gnu: Add gnome-themes-standard.
* gnu/packages/gnome.scm (gnome-themes-standard): New variable.
---
gnu/packages/gnome.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 22b73f9..d8a4fe0 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1219,3 +1219,47 @@ engineering.")
(license
;; Dual licensed under GPLv2 or GPLv3 (both without "or later")
(list license:gpl2 license:gpl3))))
+
+;; The version of this package should be the same as the version of
+;; gnome-desktop.
+(define-public gnome-themes-standard
+ (package
+ (name "gnome-themes-standard")
+ (version "3.10.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (string-take version 4) "/" name "-"
+ version ".tar.xz"))
+ (sha256
+ (base32
+ "0f2b3ypkfvrdsxcvp14ja9wqj382f1p46yrjvhhxkkjgagy6qb41"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("gtk+" ,gtk+)
+ ("gtk+-2" ,gtk+-2)
+ ("librsvg" ,librsvg)
+ ("libxml2" ,libxml2)
+ ("glib" ,glib)))
+ (native-inputs
+ `(("intltool" ,intltool)
+ ("glib:bin" ,glib "bin")
+ ("pkg-config" ,pkg-config)))
+ (arguments
+ `(#:phases
+ (alist-cons-before
+ 'build 'use-full-cache
+ ;; Use librsvg's loaders.cache instead of the one provided by
+ ;; gdk-pixbuf because the latter does not include support for SVG
+ ;; files.
+ (lambda* (#:key inputs #:allow-other-keys)
+ (setenv "GDK_PIXBUF_MODULE_FILE"
+ (car (find-files (assoc-ref inputs "librsvg")
+ "loaders\\.cache"))))
+ %standard-phases)))
+ (home-page "https://launchpad.net/gnome-themes-standard")
+ (synopsis "Default GNOME 3 themes")
+ (description
+ "The default GNOME 3 themes (Adwaita and some accessibility themes).")
+ (license license:lgpl2.1+)))
--
1.8.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gnu: Add gnome-themes-standard.
2014-11-02 17:21 [PATCH 2/2] gnu: Add gnome-themes-standard Federico Beffa
@ 2014-11-03 22:11 ` Ludovic Courtès
2014-11-04 11:15 ` Federico Beffa
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2014-11-03 22:11 UTC (permalink / raw
To: Federico Beffa; +Cc: Guix-devel
Federico Beffa <beffa@ieee.org> skribis:
> From 7439f19c1f2966466da88554478b796c3bfca429 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Sun, 2 Nov 2014 18:09:33 +0100
> Subject: [PATCH 2/2] gnu: Add gnome-themes-standard.
>
> * gnu/packages/gnome.scm (gnome-themes-standard): New variable.
[...]
> +;; The version of this package should be the same as the version of
> +;; gnome-desktop.
> +(define-public gnome-themes-standard
> + (package
> + (name "gnome-themes-standard")
> + (version "3.10.0")
Please use (version (package-version gnome-desktop)) here, and put the
comment just above it.
> + (uri (string-append "mirror://gnome/sources/" name "/"
> + (string-take version 4) "/" name "-"
Use ‘version-major+minor’ instead of ‘string-take’.
OK to push with these changes.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gnu: Add gnome-themes-standard.
2014-11-03 22:11 ` Ludovic Courtès
@ 2014-11-04 11:15 ` Federico Beffa
2014-11-04 16:52 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Federico Beffa @ 2014-11-04 11:15 UTC (permalink / raw
To: Ludovic Courtès; +Cc: Guix-devel
On Mon, Nov 3, 2014 at 11:11 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>> +;; The version of this package should be the same as the version of
>> +;; gnome-desktop.
>> +(define-public gnome-themes-standard
>> + (package
>> + (name "gnome-themes-standard")
>> + (version "3.10.0")
>
> Please use (version (package-version gnome-desktop)) here, and put the
> comment just above it.
I thought about this, but did not do it because, if the version
changes, then you also need to change the hash. So, if someone
changes gnome-desktop without bothering about gnome-themes-standard,
then the latter would break. By keeping a separate string the package
would still build, but maybe with a slight odd look. WDYT?
Regards,
Fede
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gnu: Add gnome-themes-standard.
2014-11-04 11:15 ` Federico Beffa
@ 2014-11-04 16:52 ` Ludovic Courtès
2014-11-04 17:21 ` Federico Beffa
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2014-11-04 16:52 UTC (permalink / raw
To: Federico Beffa; +Cc: Guix-devel
Federico Beffa <beffa@ieee.org> skribis:
> On Mon, Nov 3, 2014 at 11:11 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>>> +;; The version of this package should be the same as the version of
>>> +;; gnome-desktop.
>>> +(define-public gnome-themes-standard
>>> + (package
>>> + (name "gnome-themes-standard")
>>> + (version "3.10.0")
>>
>> Please use (version (package-version gnome-desktop)) here, and put the
>> comment just above it.
>
> I thought about this, but did not do it because, if the version
> changes, then you also need to change the hash. So, if someone
> changes gnome-desktop without bothering about gnome-themes-standard,
> then the latter would break.
I think using (package-version gnome-desktop) would make the intent
clear, and the breakage that would occur would give a heads-up and an
incentive to fix it.
How does that sound?
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gnu: Add gnome-themes-standard.
2014-11-04 16:52 ` Ludovic Courtès
@ 2014-11-04 17:21 ` Federico Beffa
0 siblings, 0 replies; 5+ messages in thread
From: Federico Beffa @ 2014-11-04 17:21 UTC (permalink / raw
To: Ludovic Courtès; +Cc: Guix-devel
On Tue, Nov 4, 2014 at 5:52 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> I think using (package-version gnome-desktop) would make the intent
> clear, and the breakage that would occur would give a heads-up and an
> incentive to fix it.
>
> How does that sound?
OK, fine.
Fede
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-04 17:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-02 17:21 [PATCH 2/2] gnu: Add gnome-themes-standard Federico Beffa
2014-11-03 22:11 ` Ludovic Courtès
2014-11-04 11:15 ` Federico Beffa
2014-11-04 16:52 ` Ludovic Courtès
2014-11-04 17:21 ` Federico Beffa
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.