[PATCH 5/5] gnu: Add emacs-mmm-mode

[PATCH 5/5] gnu: Add emacs-mmm-mode

[Federico Beffa]

[-- Attachment #1: Type: text/plain, Size: 5 bytes --]

Fede

[-- Attachment #2: 0005-gnu-Add-emacs-mmm-mode.patch --]
[-- Type: text/x-diff, Size: 1409 bytes --]

From 84bded85e25fd8130f222d30442027219fa8f642 Mon Sep 17 00:00:00 2001
From: Federico Beffa <beffa@fbengineering.ch>
Date: Wed, 17 Jun 2015 10:42:09 +0200
Subject: [PATCH 5/5] gnu: Add emacs-mmm-mode.

* gnu/packages/emacs.scm (emacs-mmm-mode): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 90e12e8..8d48c4f 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -800,3 +800,26 @@ mode, Rmail, Gnus, MH-E, and VM).  BBDB is fully customizable.")
 writing input files for TeX, LaTeX, ConTeXt, Texinfo, and docTeX using Emacs
 or XEmacs.")
     (license license:gpl3+)))
+
+(define-public emacs-mmm-mode
+  (package
+    (name "emacs-mmm-mode")
+    (version "0.5.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://stable.melpa.org/packages/mmm-mode-"
+             version
+             ".tar"))
+       (sha256
+        (base32
+         "1sy7m0xby2vmbx36a8b76fk850b3hcg84d9ilc120pmn71kq8k1n"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/purcell/mmm-mode")
+    (synopsis
+     "Allow Multiple Major Modes in a buffer")
+    (description
+    "MMM Mode is a minor mode that allows multiple major modes to coexist in a
+single buffer.")
+    (license license:gpl3+)))
-- 
2.2.1

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Ludovic Courtès]

Federico Beffa <beffa@ieee.org> skribis:

> From 84bded85e25fd8130f222d30442027219fa8f642 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Wed, 17 Jun 2015 10:42:09 +0200
> Subject: [PATCH 5/5] gnu: Add emacs-mmm-mode.
>
> * gnu/packages/emacs.scm (emacs-mmm-mode): New variable.

[...]

> +    (synopsis
> +     "Allow Multiple Major Modes in a buffer")

Rather: “Allow multiple major modes in an Emacs buffer”.

OK with this change, thanks!

Ludo’.

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Alex Kost]

I think I've found a problem with downloading packages from melpa-stable
(probably the same will be with 'melpa', but I don't know).  I tried to
build this 'emacs-mmm-mode' package but it failed because
<http://stable.melpa.org/packages/mmm-mode-0.5.2.tar> does not exist
anymore (because the current version is 0.5.4).

It looks like (I'm absolutely not sure though) once the new version
appears on melpa-stable, the previous tarball is being deleted, which
makes the current guix recipe of this package unusable.

-- 
Alex

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Federico Beffa]

On Wed, Jul 1, 2015 at 7:49 PM, Alex Kost <alezost@gmail.com> wrote:
> I think I've found a problem with downloading packages from melpa-stable
> (probably the same will be with 'melpa', but I don't know).  I tried to
> build this 'emacs-mmm-mode' package but it failed because
> <http://stable.melpa.org/packages/mmm-mode-0.5.2.tar> does not exist
> anymore (because the current version is 0.5.4).
>
> It looks like (I'm absolutely not sure though) once the new version
> appears on melpa-stable, the previous tarball is being deleted, which
> makes the current guix recipe of this package unusable.

Yes, version 0.5.2 didn't include the documentation. Therefore I
contacted the author and asked if he could fix it. He did and I've
updated my local patch to the new version.

I will do the last round of corrections and upload this and the other
emacs related patches when I will find some time. Probably within one
or two weeks.

Thanks for warning me about this.
Fede

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> I think I've found a problem with downloading packages from melpa-stable
> (probably the same will be with 'melpa', but I don't know).  I tried to
> build this 'emacs-mmm-mode' package but it failed because
> <http://stable.melpa.org/packages/mmm-mode-0.5.2.tar> does not exist
> anymore (because the current version is 0.5.4).

If tarball deletion or renaming is common on MELPA, then maybe we could
address it by providing an additional alternate URL, as is done for
‘lftp’ and other packages.  WDYT?

Ludo’.

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Alex Kost]

Ludovic Courtès (2015-07-04 18:16 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> I think I've found a problem with downloading packages from melpa-stable
>> (probably the same will be with 'melpa', but I don't know).  I tried to
>> build this 'emacs-mmm-mode' package but it failed because
>> <http://stable.melpa.org/packages/mmm-mode-0.5.2.tar> does not exist
>> anymore (because the current version is 0.5.4).
>
> If tarball deletion or renaming is common on MELPA, then maybe we could
> address it by providing an additional alternate URL, as is done for
> ‘lftp’ and other packages.  WDYT?

If I understand correctly, there is no alternative URL.  Only URL for a
latest version.  (but I may be wrong)

-- 
Alex

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Mark H Weaver]

Alex Kost <alezost@gmail.com> writes:

> Ludovic Courtès (2015-07-04 18:16 +0300) wrote:
>
>> Alex Kost <alezost@gmail.com> skribis:
>>
>>> I think I've found a problem with downloading packages from melpa-stable
>>> (probably the same will be with 'melpa', but I don't know).  I tried to
>>> build this 'emacs-mmm-mode' package but it failed because
>>> <http://stable.melpa.org/packages/mmm-mode-0.5.2.tar> does not exist
>>> anymore (because the current version is 0.5.4).
>>
>> If tarball deletion or renaming is common on MELPA, then maybe we could
>> address it by providing an additional alternate URL, as is done for
>> ‘lftp’ and other packages.  WDYT?
>
> If I understand correctly, there is no alternative URL.  Only URL for a
> latest version.  (but I may be wrong)

emacs-mmm-mode is failing to build on hydra, because the downloaded
tarball doesn't match the expected hash:

http://hydra.gnu.org/build/563640/nixlog/1/tail-reload

--8<---------------cut here---------------start------------->8---
starting download of `/gnu/store/gdwf9rsqvvqqb77qkgpp94w8k8z1i6wf-mmm-mode-0.5.4.tar' from `http://stable.melpa.org/packages/mmm-mode-0.5.4.tar'...

http://stable.melpa.org/.../mmm-mode-0.5.4.tar	  0.0% of 300.0 KiB (0. KiB/s)
http://stable.melpa.org/.../mmm-mode-0.5.4.tar	 21.3% of 300.0 KiB (405. KiB/s)
http://stable.melpa.org/.../mmm-mode-0.5.4.tar	 42.7% of 300.0 KiB (372. KiB/s)
http://stable.melpa.org/.../mmm-mode-0.5.4.tar	 64.0% of 300.0 KiB (439. KiB/s)
http://stable.melpa.org/.../mmm-mode-0.5.4.tar	 85.3% of 300.0 KiB (411. KiB/s)
http://stable.melpa.org/.../mmm-mode-0.5.4.tar	100.0% of 300.0 KiB (419. KiB/s)
output path `/gnu/store/gdwf9rsqvvqqb77qkgpp94w8k8z1i6wf-mmm-mode-0.5.4.tar' should have sha256 hash `1llkzb6d978ym3zv3yfzwj0w5zzmmj3ksrm5swrx1papxcnqnkb9', instead has `1kjc41nlsf7qxmmy9mrzk6myinjvc550zl5ia0ivvdz945x39yay'
--8<---------------cut here---------------end--------------->8---

What went wrong here?

      Mark

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Alex Kost]

[-- Attachment #1: Type: text/plain, Size: 3212 bytes --]

Mark H Weaver (2015-07-09 02:19 +0300) wrote:

> Alex Kost <alezost@gmail.com> writes:
>
>> Ludovic Courtès (2015-07-04 18:16 +0300) wrote:
>>
>>> Alex Kost <alezost@gmail.com> skribis:
>>>
>>>> I think I've found a problem with downloading packages from melpa-stable
>>>> (probably the same will be with 'melpa', but I don't know).  I tried to
>>>> build this 'emacs-mmm-mode' package but it failed because
>>>> <http://stable.melpa.org/packages/mmm-mode-0.5.2.tar> does not exist
>>>> anymore (because the current version is 0.5.4).
>>>
>>> If tarball deletion or renaming is common on MELPA, then maybe we could
>>> address it by providing an additional alternate URL, as is done for
>>> ‘lftp’ and other packages.  WDYT?
>>
>> If I understand correctly, there is no alternative URL.  Only URL for a
>> latest version.  (but I may be wrong)
>
> emacs-mmm-mode is failing to build on hydra, because the downloaded
> tarball doesn't match the expected hash:
>
> http://hydra.gnu.org/build/563640/nixlog/1/tail-reload
>
>
> starting download of `/gnu/store/gdwf9rsqvvqqb77qkgpp94w8k8z1i6wf-mmm-mode-0.5.4.tar' from `http://stable.melpa.org/packages/mmm-mode-0.5.4.tar'...
>
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar	  0.0% of 300.0 KiB (0. KiB/s)
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar	 21.3% of 300.0 KiB (405. KiB/s)
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar	 42.7% of 300.0 KiB (372. KiB/s)
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar	 64.0% of 300.0 KiB (439. KiB/s)
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar	 85.3% of 300.0 KiB (411. KiB/s)
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar	100.0% of 300.0 KiB (419. KiB/s)
> output path `/gnu/store/gdwf9rsqvvqqb77qkgpp94w8k8z1i6wf-mmm-mode-0.5.4.tar' should have sha256 hash `1llkzb6d978ym3zv3yfzwj0w5zzmmj3ksrm5swrx1papxcnqnkb9', instead has `1kjc41nlsf7qxmmy9mrzk6myinjvc550zl5ia0ivvdz945x39yay'
>
> What went wrong here?

Wow, it looks like using melpa(-stable) URLs are even more unreliable
than I thought.  I've just downloaded 'mmm-mode-0.5.4.tar' and the hash
is different again:

--8<---------------cut here---------------start------------->8---
$ guix download http://stable.melpa.org/packages/mmm-mode-0.5.4.tar
starting download of `/tmp/guix-file.V1XHG4' from `http://stable.melpa.org/packages/mmm-mode-0.5.4.tar'...
http://stable.melpa.org/.../mmm-mode-0.5.4.tar	100.0% of 300.0 KiB (110. KiB/s)
/gnu/store/mqkacn4hm16j7cx91g4ml9287bznfva1-mmm-mode-0.5.4.tar
0bsbp93wb5b78yp2gyvk4jkmv6vawcwyyfy35wbq6hdfi5q75a9w
--8<---------------cut here---------------end--------------->8---

So my guess is: MELPA periodically updates all the tarballs, not just
the packages with the new version tags.  I think it means we should
refuse from using melpa(-stable) tarballs and use the upstream releases
instead.  In this particular case it will be
<https://github.com/purcell/mmm-mode/archive/0.5.4.tar.gz>.

Also I think if an emacs package provides a proper gnu build system it
should be prefered over the emacs build system (as it may provide tests
and, dunno, it's just the usual way to go).  If people agree on this,
what about the attached patch?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-emacs-mmm-mode-Use-gnu-build-system.patch --]
[-- Type: text/x-patch, Size: 2045 bytes --]

From 35e622f13b5971ffab154da2ed316c2076c0c652 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Thu, 9 Jul 2015 11:48:12 +0300
Subject: [PATCH] gnu: emacs-mmm-mode: Use gnu-build-system.

* gnu/packages/emacs.scm (emacs-mmm-mode): Replace melpa-stable URL with
  the github URL and use 'gnu-build-system' instead of
  'emacs-build-system'.  Fix typo (add missing space before the
  description).
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index f00e15c..32b27fc 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -812,17 +812,27 @@ or XEmacs.")
      (origin
        (method url-fetch)
        (uri (string-append
-             "http://stable.melpa.org/packages/mmm-mode-"
-             version
-             ".tar"))
+             "https://github.com/purcell/mmm-mode/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
        (sha256
         (base32
-         "1llkzb6d978ym3zv3yfzwj0w5zzmmj3ksrm5swrx1papxcnqnkb9"))))
-    (build-system emacs-build-system)
+         "10kwslnflbjqm62wkrq420crqzdqalzfflp9pqk1i12zm6dm4mfv"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'autogen
+           (lambda _
+             (zero? (system* "sh" "autogen.sh")))))))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("emacs" ,emacs-no-x)
+       ("texinfo" ,texinfo)))
     (home-page "https://github.com/purcell/mmm-mode")
-    (synopsis
-     "Allow multiple major modes in an Emacs buffer")
+    (synopsis "Allow multiple major modes in an Emacs buffer")
     (description
-    "MMM Mode is a minor mode that allows multiple major modes to coexist in a
+     "MMM Mode is a minor mode that allows multiple major modes to coexist in a
 single buffer.")
     (license license:gpl3+)))
-- 
2.4.3

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Federico Beffa]

On Thu, Jul 9, 2015 at 1:19 AM, Mark H Weaver <mhw@netris.org> wrote:
> Alex Kost <alezost@gmail.com> writes:
>
>> Ludovic Courtès (2015-07-04 18:16 +0300) wrote:
>>
>>> Alex Kost <alezost@gmail.com> skribis:
>>>
>>>> I think I've found a problem with downloading packages from melpa-stable
>>>> (probably the same will be with 'melpa', but I don't know).  I tried to
>>>> build this 'emacs-mmm-mode' package but it failed because
>>>> <http://stable.melpa.org/packages/mmm-mode-0.5.2.tar> does not exist
>>>> anymore (because the current version is 0.5.4).
>>>
>>> If tarball deletion or renaming is common on MELPA, then maybe we could
>>> address it by providing an additional alternate URL, as is done for
>>> ‘lftp’ and other packages.  WDYT?
>>
>> If I understand correctly, there is no alternative URL.  Only URL for a
>> latest version.  (but I may be wrong)
>
> emacs-mmm-mode is failing to build on hydra, because the downloaded
> tarball doesn't match the expected hash:
>
> http://hydra.gnu.org/build/563640/nixlog/1/tail-reload
>
> --8<---------------cut here---------------start------------->8---
> starting download of `/gnu/store/gdwf9rsqvvqqb77qkgpp94w8k8z1i6wf-mmm-mode-0.5.4.tar' from `http://stable.melpa.org/packages/mmm-mode-0.5.4.tar'...
>
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar    0.0% of 300.0 KiB (0. KiB/s)
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar   21.3% of 300.0 KiB (405. KiB/s)
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar   42.7% of 300.0 KiB (372. KiB/s)
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar   64.0% of 300.0 KiB (439. KiB/s)
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar   85.3% of 300.0 KiB (411. KiB/s)
> http://stable.melpa.org/.../mmm-mode-0.5.4.tar  100.0% of 300.0 KiB (419. KiB/s)
> output path `/gnu/store/gdwf9rsqvvqqb77qkgpp94w8k8z1i6wf-mmm-mode-0.5.4.tar' should have sha256 hash `1llkzb6d978ym3zv3yfzwj0w5zzmmj3ksrm5swrx1papxcnqnkb9', instead has `1kjc41nlsf7qxmmy9mrzk6myinjvc550zl5ia0ivvdz945x39yay'
> --8<---------------cut here---------------end--------------->8---
>
> What went wrong here?

That's not a good sign. I still have in the store the tar file with
the hash indicated in the package and it builds fine. However, if I
'guix download ...' the file again I get a hash which is different
from the one in the package and also from the one in the hydra log.

I can imagine that melpa is building the tar file on the fly. Is guix
taking the time stamp as an input to determine the hash?

Fede

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Mark H Weaver]

Federico Beffa <beffa@ieee.org> writes:

> On Thu, Jul 9, 2015 at 1:19 AM, Mark H Weaver <mhw@netris.org> wrote:
>> emacs-mmm-mode is failing to build on hydra, because the downloaded
>> tarball doesn't match the expected hash:
>>
>> http://hydra.gnu.org/build/563640/nixlog/1/tail-reload
>>
>> --8<---------------cut here---------------start------------->8---
>> starting download of `/gnu/store/gdwf9rsqvvqqb77qkgpp94w8k8z1i6wf-mmm-mode-0.5.4.tar' from `http://stable.melpa.org/packages/mmm-mode-0.5.4.tar'...
>>
>> http://stable.melpa.org/.../mmm-mode-0.5.4.tar    0.0% of 300.0 KiB (0. KiB/s)
>> http://stable.melpa.org/.../mmm-mode-0.5.4.tar   21.3% of 300.0 KiB (405. KiB/s)
>> http://stable.melpa.org/.../mmm-mode-0.5.4.tar   42.7% of 300.0 KiB (372. KiB/s)
>> http://stable.melpa.org/.../mmm-mode-0.5.4.tar   64.0% of 300.0 KiB (439. KiB/s)
>> http://stable.melpa.org/.../mmm-mode-0.5.4.tar   85.3% of 300.0 KiB (411. KiB/s)
>> http://stable.melpa.org/.../mmm-mode-0.5.4.tar  100.0% of 300.0 KiB (419. KiB/s)
>> output path
>> `/gnu/store/gdwf9rsqvvqqb77qkgpp94w8k8z1i6wf-mmm-mode-0.5.4.tar'
>> should have sha256 hash
>> `1llkzb6d978ym3zv3yfzwj0w5zzmmj3ksrm5swrx1papxcnqnkb9', instead has
>> `1kjc41nlsf7qxmmy9mrzk6myinjvc550zl5ia0ivvdz945x39yay'
>> --8<---------------cut here---------------end--------------->8---
>>
>> What went wrong here?
>
> That's not a good sign. I still have in the store the tar file with
> the hash indicated in the package and it builds fine. However, if I
> 'guix download ...' the file again I get a hash which is different
> from the one in the package and also from the one in the hydra log.
>
> I can imagine that melpa is building the tar file on the fly. Is guix
> taking the time stamp as an input to determine the hash?

Guix is taking a hash of the complete contents of the downloaded file,
i.e. all of the bytes inside the file.  That, of course, includes
timestamps from inside the tar file, but not any metadata of the file
itself.

      Mark

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> So my guess is: MELPA periodically updates all the tarballs, not just
> the packages with the new version tags.  I think it means we should
> refuse from using melpa(-stable) tarballs and use the upstream releases
> instead.  In this particular case it will be
> <https://github.com/purcell/mmm-mode/archive/0.5.4.tar.gz>.

Agreed.

Ludo’.

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Federico Beffa]

Alex Kost <alezost@gmail.com> writes:

> ...  If people agree on this,
> what about the attached patch?

Does it install the documentation info file? If so, just push it.

Thanks,
Fede

>
>
> From 35e622f13b5971ffab154da2ed316c2076c0c652 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Thu, 9 Jul 2015 11:48:12 +0300
> Subject: [PATCH] gnu: emacs-mmm-mode: Use gnu-build-system.
>
> * gnu/packages/emacs.scm (emacs-mmm-mode): Replace melpa-stable URL with
>   the github URL and use 'gnu-build-system' instead of
>   'emacs-build-system'.  Fix typo (add missing space before the
>   description).
> ---
>  gnu/packages/emacs.scm | 26 ++++++++++++++++++--------
>  1 file changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index f00e15c..32b27fc 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -812,17 +812,27 @@ or XEmacs.")
>       (origin
>         (method url-fetch)
>         (uri (string-append
> -             "http://stable.melpa.org/packages/mmm-mode-"
> -             version
> -             ".tar"))
> +             "https://github.com/purcell/mmm-mode/archive/"
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
>         (sha256
>          (base32
> -         "1llkzb6d978ym3zv3yfzwj0w5zzmmj3ksrm5swrx1papxcnqnkb9"))))
> -    (build-system emacs-build-system)
> +         "10kwslnflbjqm62wkrq420crqzdqalzfflp9pqk1i12zm6dm4mfv"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'autogen
> +           (lambda _
> +             (zero? (system* "sh" "autogen.sh")))))))
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("emacs" ,emacs-no-x)
> +       ("texinfo" ,texinfo)))
>      (home-page "https://github.com/purcell/mmm-mode")
> -    (synopsis
> -     "Allow multiple major modes in an Emacs buffer")
> +    (synopsis "Allow multiple major modes in an Emacs buffer")
>      (description
> -    "MMM Mode is a minor mode that allows multiple major modes to coexist in a
> +     "MMM Mode is a minor mode that allows multiple major modes to coexist in a
>  single buffer.")
>      (license license:gpl3+)))

Re: [PATCH 5/5] gnu: Add emacs-mmm-mode

[Alex Kost]

Federico Beffa (2015-07-18 12:16 +0300) wrote:

> Alex Kost <alezost@gmail.com> writes:
>
>> ...  If people agree on this,
>> what about the attached patch?
>
> Does it install the documentation info file? If so, just push it.

Yes, the info is installed.  Pushed, thanks.

-- 
Alex