From mboxrd@z Thu Jan  1 00:00:00 1970
From: Federico Beffa <beffa@ieee.org>
Subject: Re: [PATCH 6/6] gnu: Add emacs-slime.
Date: Thu, 31 Dec 2015 11:32:35 +0100
Message-ID: <CAKrPhPM0hDFwydBhsygxjgh62PHpx8H_17RxcDmtN8+mRac_ow@mail.gmail.com>
References: <CAKrPhPNBb2FoSGNM9cPgQe2i=7RQcKJyx6gzPo+4QW+SFO0KvQ@mail.gmail.com>
	<87a8oqgbws.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40565)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1aEaX8-0002xD-41
	for guix-devel@gnu.org; Thu, 31 Dec 2015 05:32:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1aEaX6-0000x3-Qg
	for guix-devel@gnu.org; Thu, 31 Dec 2015 05:32:38 -0500
Received: from mail-vk0-x22b.google.com ([2607:f8b0:400c:c05::22b]:32783)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1aEaX6-0000wm-IE
	for guix-devel@gnu.org; Thu, 31 Dec 2015 05:32:36 -0500
Received: by mail-vk0-x22b.google.com with SMTP id a188so216116051vkc.0
	for <guix-devel@gnu.org>; Thu, 31 Dec 2015 02:32:36 -0800 (PST)
In-Reply-To: <87a8oqgbws.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>

On Thu, Dec 31, 2015 at 11:17 AM, Alex Kost <alezost@gmail.com> wrote:
> Federico Beffa (2015-12-30 20:33 +0300) wrote:
>
> [...]
>> +(define-public emacs-slime
>> +  (package
>> +    (name "emacs-slime")
>> +    (version "2.15")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/slime/slime/archive/v"
>> +             version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0l2z6l2xm78mhh0nczkrmzh2ddb1n911ij9xb6q40zwvx4f8blds"))))
>> +    (build-system emacs-build-system)
>> +    (inputs
>> +     `(("texlive" ,texlive)
>> +       ("texinfo" ,texinfo)))
>
> As these inputs are used just for generating documentation, I think they
> should be in 'native-inputs'.

yes. will change that.

>
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'install 'configure
>> +           (lambda* _
>> +             (substitute* "slime.el"
>> +               (("inferior-lisp-program \"lisp\"")
>> +                "inferior-lisp-program \"sbcl\""))
>> +             #t))
>
> Why do you name this phase 'configure'?  Actually I think this phase is
> not needed, because 'inferior-lisp-program' should be set by a user to
> whatever implementation (s)he prefers.

It's called configure because I'm configuring a default CL implementation.

The default value in slime is 'lisp'. I only used CLISP and SBCL and
none of them provides a binary called 'lisp'. For this reason I tough
it to be a good idea to provide a default name corresponding to an
existing binary.

Of course the user has to adapt to its own needs.

Thanks.
Fede