From: Federico Beffa <beffa@ieee.org>
To: Alex Kost <alezost@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 6/6] gnu: Add emacs-slime.
Date: Thu, 31 Dec 2015 11:32:35 +0100 [thread overview]
Message-ID: <CAKrPhPM0hDFwydBhsygxjgh62PHpx8H_17RxcDmtN8+mRac_ow@mail.gmail.com> (raw)
In-Reply-To: <87a8oqgbws.fsf@gmail.com>
On Thu, Dec 31, 2015 at 11:17 AM, Alex Kost <alezost@gmail.com> wrote:
> Federico Beffa (2015-12-30 20:33 +0300) wrote:
>
> [...]
>> +(define-public emacs-slime
>> + (package
>> + (name "emacs-slime")
>> + (version "2.15")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://github.com/slime/slime/archive/v"
>> + version ".tar.gz"))
>> + (sha256
>> + (base32
>> + "0l2z6l2xm78mhh0nczkrmzh2ddb1n911ij9xb6q40zwvx4f8blds"))))
>> + (build-system emacs-build-system)
>> + (inputs
>> + `(("texlive" ,texlive)
>> + ("texinfo" ,texinfo)))
>
> As these inputs are used just for generating documentation, I think they
> should be in 'native-inputs'.
yes. will change that.
>
>> + (arguments
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (add-before 'install 'configure
>> + (lambda* _
>> + (substitute* "slime.el"
>> + (("inferior-lisp-program \"lisp\"")
>> + "inferior-lisp-program \"sbcl\""))
>> + #t))
>
> Why do you name this phase 'configure'? Actually I think this phase is
> not needed, because 'inferior-lisp-program' should be set by a user to
> whatever implementation (s)he prefers.
It's called configure because I'm configuring a default CL implementation.
The default value in slime is 'lisp'. I only used CLISP and SBCL and
none of them provides a binary called 'lisp'. For this reason I tough
it to be a good idea to provide a default name corresponding to an
existing binary.
Of course the user has to adapt to its own needs.
Thanks.
Fede
next prev parent reply other threads:[~2015-12-31 10:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 17:33 [PATCH 6/6] gnu: Add emacs-slime Federico Beffa
2015-12-31 0:55 ` Ben Woodcroft
2015-12-31 9:12 ` Federico Beffa
2016-01-05 22:17 ` Ludovic Courtès
2016-01-09 10:30 ` Federico Beffa
2016-01-09 15:27 ` Alex Kost
2016-01-09 18:45 ` Ludovic Courtès
2015-12-31 9:52 ` Ricardo Wurmus
2015-12-31 23:52 ` Alex Kost
2016-01-01 8:25 ` Ricardo Wurmus
2016-01-01 8:35 ` Ben Woodcroft
2016-01-01 15:04 ` Ricardo Wurmus
2016-01-05 14:25 ` [PATCH] import: Move beautify description from cran to utils. (was Re: [PATCH 6/6] gnu: Add emacs-slime.) Ben Woodcroft
2016-01-10 21:17 ` Ludovic Courtès
2016-01-14 9:49 ` Ben Woodcroft
2016-01-14 10:31 ` Ricardo Wurmus
2016-01-14 10:53 ` Ben Woodcroft
2016-01-14 11:30 ` Ricardo Wurmus
2016-01-14 12:15 ` Ben Woodcroft
2016-01-17 1:00 ` [PATCH] import: Move beautify description from cran to utils Ben Woodcroft
2016-01-18 9:45 ` Ludovic Courtès
2016-01-20 22:13 ` Ben Woodcroft
2016-01-21 8:51 ` Ludovic Courtès
2015-12-31 10:17 ` [PATCH 6/6] gnu: Add emacs-slime Alex Kost
2015-12-31 10:32 ` Federico Beffa [this message]
2015-12-31 20:40 ` Alex Kost
2015-12-31 10:33 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKrPhPM0hDFwydBhsygxjgh62PHpx8H_17RxcDmtN8+mRac_ow@mail.gmail.com \
--to=beffa@ieee.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.