From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35200) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihGOB-0003Ns-K5 for guix-patches@gnu.org; Tue, 17 Dec 2019 12:12:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihGOA-0005gu-6X for guix-patches@gnu.org; Tue, 17 Dec 2019 12:12:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36371) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihGOA-0005gj-3U for guix-patches@gnu.org; Tue, 17 Dec 2019 12:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ihGO9-00047Y-U1 for guix-patches@gnu.org; Tue, 17 Dec 2019 12:12:01 -0500 Subject: [bug#38640] [PATCH] Add ripgrep and many rust dependencies Resent-Message-ID: MIME-Version: 1.0 References: <002582d46228db8739fc12c0404ad177@riseup.net> In-Reply-To: <002582d46228db8739fc12c0404ad177@riseup.net> From: John Soo Date: Tue, 17 Dec 2019 17:10:51 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000a278560599e96964" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Martin Becze Cc: Guix-patches , 38640@debbugs.gnu.org --000000000000a278560599e96964 Content-Type: text/plain; charset="UTF-8" HI everyone, I did some work on your review and have a couple questions before I submit the next patchset. * My questions for Martin: > I'm trying to convince everyone to leave in the crago-inputs > dependencies and add a "#:skip-build? #t" to the build arguments for all > source pakages. That way we don't have to specify the transient > dependencies at the top level package. I like this idea. I think I will do it if you don't mind. It's either that or add hidden? #t to the properties, right? Whether to add #skip-build? #t to the packages is the last piece of review I need to fixup. * Discussion for Nicolo: > - rust-demo-hack@0.0.5: all the source URIs are unreachable I guix build rust-demo-hack@0.0 and got the download. Maybe it was a temporary network issue or something? > Also: > - rust-miniz-oxide-c-api-0.2: defined but not used It is used by at least rust-flate2 I think. * Work I did based on Nicolo's suggestions: ** Fixed > Looking at them quickly, I noticed the following have the "a" in add lowercase: > > - [PATCH 160/206] gnu: add rust-flamer-0.3. > - [PATCH 073/206] gnu: add rust-tokio-sync-0.1. ** Fixed > - contains an undefined reference to rust-libc-0.2.58 Ah, that's because I left off my first package from the patchset. It will be included next round. > - rust-futures-channel-preview-0.3: home moved to > https://rust-lang.github.io/futures-rs/ ** Fixed. > - descriptions not ending in dot: Thanks, looking forward to having ripgrep upstream :) - John --000000000000a278560599e96964 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
HI everyone,

I did some work= on your review and have a couple questions before I submit the next patchs= et.

* My questions for Martin:

>=20 I'm trying to convince everyone to leave in the crago-inputs
> dependencies and add a "#:skip-build? #t" to the build argum= ents for all
> source pakages. That way we don't have to specify the transient > dependencies at the top level package.

I= like this idea. I think I will do it if you don't mind. It's eithe= r that or add hidden? #t to the properties, right?
Whether to add= #skip-build? #t to the packages is the last piece of review I need to fixu= p.

* Discussion for Nicolo:

> - rust-demo-hack@0.0.5: all the source URIs are unreachable
=
I guix build rust-demo-hack@0.0 and got the download. Maybe = it was a temporary network issue or something?

> Also:
> - rust-miniz-oxide-c-api-0.2: defined but not used

It is used by at least rust-flate2 I think.
* Work I did based on Nicolo's suggestions:

<= /div>
** Fixed
> Looking at them quickly, I noticed th= e following have the "a" in add lowercase:
>
> - [PATCH 160/206] gnu: add rust-flamer-0.3.
> - [PATCH 073/206] gnu: add rust-tokio-sync-0.1.

** Fixed
> =C2=A0 - contains an undefined reference to rust-libc-0.2.58

Ah, that's because I left off my first package from the= patchset. It will be included next round.

> - rust-futures-channel-preview-0.3: home moved to
> =C2=A0 https://rust-lang.github.io/futures-rs/
=

** Fixed.
> - descriptions not ending in dot:

Thanks, loo= king forward to having ripgrep upstream :)

- John<= br>
--000000000000a278560599e96964--