From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dennis Mungai Subject: Re: [PATCH] Add ocl-icd to GNU Guix Date: Mon, 21 Mar 2016 14:45:31 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahyH7-00041Q-QU for guix-devel@gnu.org; Mon, 21 Mar 2016 07:45:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahyH6-0008V6-M0 for guix-devel@gnu.org; Mon, 21 Mar 2016 07:45:33 -0400 Received: from mail-yw0-x231.google.com ([2607:f8b0:4002:c05::231]:35663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahyH6-0008V2-GI for guix-devel@gnu.org; Mon, 21 Mar 2016 07:45:32 -0400 Received: by mail-yw0-x231.google.com with SMTP id g127so211368060ywf.2 for ; Mon, 21 Mar 2016 04:45:32 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org Hello Ricardo, Thanks for your valuable input. I'll address the issues raised and re-submit the patches to the stated stan= dard. Regards, Dennis. On 21 March 2016 at 13:56, Ricardo Wurmus wr= ote: > > Hi Dennis, > >> The attached patch adds ocl-icd (An OpenCL ICD Loader) to GNU Guix. > > Thanks! > > I=E2=80=99m confused about this, because I just reviewed two other patche= s from > you that also contained definitions for =E2=80=9Cocl-icd=E2=80=9D and =E2= =80=9Copencl-headers=E2=80=9D. > Which of these is the latest version? > > It would be helpful if you created one patch per package only. > > ~~ Ricardo