From: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add sdparm.
Date: Tue, 2 Feb 2016 17:30:07 +0100 [thread overview]
Message-ID: <CAKFHe2QXt=mXtdjRZBCC3soSkHx=oxyfJQ3PG2hFy4pbrtuh8w@mail.gmail.com> (raw)
In-Reply-To: <idjk2mn9z6m.fsf@bimsb-sys02.mdc-berlin.net>
On 2 February 2016 at 11:36, Ricardo Wurmus
<ricardo.wurmus@mdc-berlin.de> wrote:
>
> tobias.geerinckx.rice@gmail.com writes:
>
>> From: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
>>
>> * gnu/packages/disk.scm (sdparm): New variable.
>> ---
>> gnu/packages/disk.scm | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>
> This patch looks very good! Thank you!
>
>> + (description "Sdparm reads and modifies SCSI device parameters.
>> +These devices can be SCSI disks, in which case @command{sdparm}'s role is
>> +similar to its namesake: the Linux @command{hdparm} utility originally
>> +designed for ATA disks. However, @command{sdparm} can be used to access
>> +parameters on any device that uses a SCSI command set. Such devices
>> +include CD/DVD drives (irrespective of transport), SCSI and ATAPI tape
>> +drives, and SCSI enclosures. A small set of commands associated with
>> +starting and stopping the media, loading and unloading removable media
>> +and some other housekeeping functions can also be sent with this utility.")
>
> I would remove “Linux” from the description as neither “sdparm” nor
> “hdparm” seem to have anything to do with the kernel.
This caught my suspicion as well, but then hdparm turned out to be in
linux.scm and I dwelt no further on the matter. Go ahead!
>
> “[...] functions can [...] be sent” sounds odd to me. It probably is
> meant to be understood as “commands associated with [...] housekeeping
> functions”, but that’s not how I parsed it at first. Maybe it would be
> clearer to reorder the sentence as “This utility can also send commands
> associated with [this, that, and] some other housekeeping functions”.
>
> If you’re okay with these changes I’ll push it after these slight
> modifications.
Both are certainly improvements. Thank you for your help!
> Thanks again and welcome!
I'm going to have to use Emacs, aren't I...
> ~~ Ricardo
T G-R
next prev parent reply other threads:[~2016-02-02 16:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 7:04 Adding a first package tobias.geerinckx.rice
2016-02-02 7:04 ` [PATCH] gnu: Add sdparm tobias.geerinckx.rice
2016-02-02 8:52 ` Tobias Geerinckx-Rice
2016-02-02 10:36 ` Ricardo Wurmus
2016-02-02 16:30 ` Tobias Geerinckx-Rice [this message]
2016-02-02 16:39 ` Andreas Enge
2016-02-02 16:50 ` Tobias Geerinckx-Rice
2016-02-02 17:01 ` Andreas Enge
2016-02-05 8:31 ` Ricardo Wurmus
-- strict thread matches above, loose matches on Subject: below --
2016-02-02 0:20 Add sdparm SCSI command utility tobias.geerinckx.rice
2016-02-02 0:20 ` [PATCH] gnu: Add sdparm tobias.geerinckx.rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKFHe2QXt=mXtdjRZBCC3soSkHx=oxyfJQ3PG2hFy4pbrtuh8w@mail.gmail.com' \
--to=tobias.geerinckx.rice@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.