From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: [PATCH] gnu: simple-scan: Update to 3.19.91. Date: Wed, 9 Mar 2016 00:43:52 +0100 Message-ID: References: <1457474675-21775-1-git-send-email-tobias.geerinckx.rice@gmail.com> <20160308230232.GA24107@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adRIA-0000BA-JB for guix-devel@gnu.org; Tue, 08 Mar 2016 18:43:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adRI9-0004c5-JJ for guix-devel@gnu.org; Tue, 08 Mar 2016 18:43:54 -0500 Received: from mail-ob0-x231.google.com ([2607:f8b0:4003:c01::231]:34143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adRI9-0004bt-Ct for guix-devel@gnu.org; Tue, 08 Mar 2016 18:43:53 -0500 Received: by mail-ob0-x231.google.com with SMTP id ts10so30461262obc.1 for ; Tue, 08 Mar 2016 15:43:53 -0800 (PST) In-Reply-To: <20160308230232.GA24107@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Hullo Leo, On 09/03/2016, Leo Famulari wrote: > Except where necessary for the new version to work, it's best to do > updates in a separate commit from other changes. > > I can apply the update myself if you say it's okay to do on its own, or > feel free to submit a revised patch set. Er, no. This whole thing is pretty =E2=80=94 what's the eufemism =E2=80=94 = atomic: PackageKit support is a =E2=80=98new=E2=80=99 upstream addition. Guix doesn= 't ship a PackageKit expression. Nor would writing one add much value, since its sole purpose is to serve as an abstraction layer for other, =E2=80=98impure= =E2=80=99 package managers[1]. I therefore simply disabled it. > Does 'src/ui.c' cause problems for us? I'd rather not make changes to > upstream code except when necesssary [0], at least not without > discussing it with upstream first. However, a stale file (src/ui.c) in the tarball still references packagekit= : make[1]: Entering directory '/tmp/guix-build-simple-scan-3.19.91.drv-0/build/src' CC simple_scan-ui.o ../../simple-scan-3.19.91/src/ui.c:28:41: fatal error: \ packagekit-glib2/packagekit.h: No such file or directory #include "packagekit-glib2/packagekit.h" Simply adding =E2=80=98make clean=E2=80=99 doesn't work (because that assum= es we're building in the source directory and Guix doesn't). Removing the offending file fixes the build & seemed more clear. > [0] [...] The impact of the change should be > well-understood by reviewers, at the very least ;) Would a simple s/PackageKit support/newly-introduced &/ on the commit message make this clear? Or should I be more verbose? Kind regards, T G-R [1] Simple Scan then invokes PackageKit to automagically install missing sane backends.