all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Yuval Langer <yuval.langer@gmail.com>
To: 68448@debbugs.gnu.org
Subject: [bug#68448] Fwd: bug#68448: Add guile-rsv package definition.
Date: Tue, 6 Feb 2024 15:15:50 +0200	[thread overview]
Message-ID: <CAK0OjG0T2Y8au6f0boHH4zNZ5VYkZV4jr00OsJFaW-4AUjrj9A@mail.gmail.com> (raw)
In-Reply-To: <CAK0OjG095jgS6PyvRVADL_vogndBVnX7gSty90ccpJdTOfw36w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

(re-sending to the debbugs thread)

On Sun, Jan 28, 2024 at 11:34 PM Ludovic Courtès <ludo@gnu.org> wrote:
> Nice!

Thank you!

> Could you please follow the conventions and style used elsewhere in the
> code, in particular regarding how to deal with snapshots, avoiding
> square brackets, possibly running ‘guix style guile-rsv’, and writing
> synopsis and description following our guidelines:
>
>   https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html
>   https://guix.gnu.org/manual/devel/en/html_node/Version-Numbers.html
>
> Could you send an updated version?

I have:

- Replaced the square brackets with parentheses in the let
  definitions,
- added a revision number and used `git-version`,
- rewrote the synopsis and description,
- checked the style with `guix style -L . guile-rsv` in my own Guix
  channel with this guile-rsv package definition, which seems to show
  no style errors or recommendations, and

I hope these are sufficient.

> Thanks in advance!
>
> Ludo’.

Thank you!
Yuval Langer.

[-- Attachment #2: 0001-Add-guile-rsv-package-definition.patch --]
[-- Type: application/x-patch, Size: 4302 bytes --]

  parent reply	other threads:[~2024-02-06 13:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-14 13:03 [bug#68448] Add guile-rsv package definition Yuval Langer
2024-01-28 21:34 ` Ludovic Courtès
     [not found]   ` <CAK0OjG095jgS6PyvRVADL_vogndBVnX7gSty90ccpJdTOfw36w@mail.gmail.com>
2024-02-06 13:15     ` Yuval Langer [this message]
2024-04-17  9:06       ` bug#68448: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK0OjG0T2Y8au6f0boHH4zNZ5VYkZV4jr00OsJFaW-4AUjrj9A@mail.gmail.com \
    --to=yuval.langer@gmail.com \
    --cc=68448@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.