From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oE/FDkiAA2VWWgEAG6o9tA:P1 (envelope-from ) for ; Thu, 14 Sep 2023 23:51:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oE/FDkiAA2VWWgEAG6o9tA (envelope-from ) for ; Thu, 14 Sep 2023 23:51:04 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC888539DC for ; Thu, 14 Sep 2023 23:51:03 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=atai-org.20230601.gappssmtp.com header.s=20230601 header.b=Jbmd6qDi; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694728264; a=rsa-sha256; cv=none; b=l7N23SBcPZqfWIC5rFnS0aNDz9n4PP6F+yXfJpcbpPNOW0cOoD02bmqZYeTClUUBHP1PEO zX5nWJq7eedPC9Mr/UB0Md8ghndV3qfL7y62AlFqFUNj51FN7v5mdSZ+U3ae3VzzNoWn0J hQ8QUSO1WK8yqohiR9n1xxQuKA6fNxGLhowNgYGmjuMlA4LQYJ0cTHidijE4npg4+7MDR+ BoyWI7M3WxGYhWXjL9mQnsZTsc4cwuUfK090rM0KQvd2XxQzB1SZlFBWGQd95Pvgiuvacc TamfnN/9pDCR8oMq/ysz2wxFXMsLZz3D4TfCP2AwpvvMGmDBBdofrDrSJRd16w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694728264; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=5GzvHwKQzkyF9e6i3zzQxwFk3n2kT+WLFiY2ycgMZTY=; b=C77YmemSNuh9obnTMb6o60391RaxsG+eGdxcUtOQ+zpivXcOHYyW54X+MLa+oGIWDy3tnW Ym2AeRuA2rbSFhUrdJy0Ku1GFQax2oKNzaWr1vNKQ0S1ycR6HLpNEGr7FTfVA12LA45jMI mm8R5LLObj8YZLUCBA2JuzQ5cRq2T1XUCPMvogVcqTx2yFEw/EH8UfjA9Sx62sl0xJOXEn Tssr0FhckrDbCD7yVsuOgluGejsggZxXxq5XfCiJizeG2/f46CNOhyvPbHHrzlxL82BeTD RKSa+KIOwQihDN+TJvVcTfv0q1PYD+7sQidGpJhovdRw0KCPHdg4eMOxxDSwWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=atai-org.20230601.gappssmtp.com header.s=20230601 header.b=Jbmd6qDi; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qguEk-000105-Lg; Thu, 14 Sep 2023 17:50:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qguEi-0000zf-Pc for guix-patches@gnu.org; Thu, 14 Sep 2023 17:50:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qguEi-00058K-IU for guix-patches@gnu.org; Thu, 14 Sep 2023 17:50:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qguEo-0005n9-JI for guix-patches@gnu.org; Thu, 14 Sep 2023 17:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65835] [PATCH] gnu: tensorflow-lite: Update to 2.13.0 Resent-From: Andy Tai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 14 Sep 2023 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65835 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 65835@debbugs.gnu.org Received: via spool by 65835-submit@debbugs.gnu.org id=B65835.169472822222214 (code B ref 65835); Thu, 14 Sep 2023 21:51:02 +0000 Received: (at 65835) by debbugs.gnu.org; 14 Sep 2023 21:50:22 +0000 Received: from localhost ([127.0.0.1]:41388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qguE9-0005mD-H0 for submit@debbugs.gnu.org; Thu, 14 Sep 2023 17:50:21 -0400 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]:61864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qguE4-0005lt-50 for 65835@debbugs.gnu.org; Thu, 14 Sep 2023 17:50:19 -0400 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6c0c6370e5eso846210a34.3 for <65835@debbugs.gnu.org>; Thu, 14 Sep 2023 14:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20230601.gappssmtp.com; s=20230601; t=1694728204; x=1695333004; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5GzvHwKQzkyF9e6i3zzQxwFk3n2kT+WLFiY2ycgMZTY=; b=Jbmd6qDiAIgfDyiqBWJTYSHkyUtxTdlnOEIysX8Lmauko2cLdDK3NOTjRXyrtUWZR9 oolaAYhUv7KRaVRV7mU7zEwzxmr2zhLLpEuz1JuB0C0/gL3z/xKSrgXmqeYl2TdfVK+K byuCryYc+vrO+5/Jedjk3wobOJbJgQRJPGso8aOdZjyjh8BKneCLcj0YJChepHW+exsK 57QCkTy35t+Slsf0soN1IcGuHJAxwU00Upc9ZJ5mxnKPu2ogj//Iqd7AxMgYlgaQcuAc Z6Rsmx9RTVq7dcMN/aVWj6JTH2QiHkOrptAnVvuy+LVErLGz+xfa8rLK2Jk92/v9V548 +QnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694728204; x=1695333004; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5GzvHwKQzkyF9e6i3zzQxwFk3n2kT+WLFiY2ycgMZTY=; b=fSr9xd9uRST9P9OcqN1pHCvTN3bxfvXQKX6mmh0eon78s6SlXOf65tUTt6Yg7cqqKn cpWQg7pvCPLhoB8m3V8dPk00nwUkRxIvpFZT1EYh0uNBCfRh53FFuyI5G7lXKVVC/Qkm Xh2gNh77ZHL5sXEhONnoo5dg2diwmQu9bvlLNuawbVg6qrvfCAwlMU6ESosGuwPzx++V WrA6gkmX80IIQg1WgRoP7ldNmvTlNEkcS8NP/bOrkLq3wUMnt3XMFGnof14BdkTj7/DA 6uU0IxfQ9nIqAdlp/agoBIKikRiHwZbbbd81FvjRwp13ditfYpORPZyqGAdJ7/VIVGit 0B1w== X-Gm-Message-State: AOJu0YwvgcNKu8XU8lhlElLh0bQRpMXaQozjjAtqaus71cx0VxYUKusV pD96JsZOhE57NnFSH5u7pNTmfFZp5uZa/dADGTRq6ngfzNE= X-Google-Smtp-Source: AGHT+IGlMe1Smjw693whqb/eyx9G4ASL9Qg4tIMT0qQujTMddIhMNZem3P2WforJkT7JcVuGU81107gXMVTWtizi/NM= X-Received: by 2002:a05:6830:e86:b0:6b9:b226:d08e with SMTP id dp6-20020a0568300e8600b006b9b226d08emr6734928otb.34.1694728204419; Thu, 14 Sep 2023 14:50:04 -0700 (PDT) MIME-Version: 1.0 References: <87ttrw3005.fsf_-_@gnu.org> In-Reply-To: <87ttrw3005.fsf_-_@gnu.org> From: Andy Tai Date: Thu, 14 Sep 2023 14:49:28 -0700 Message-ID: Content-Type: multipart/alternative; boundary="0000000000009d86cd060558a876" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.22 X-Spam-Score: -5.22 X-Migadu-Queue-Id: CC888539DC X-Migadu-Scanner: mx2.migadu.com X-TUID: R0bdoc2zEuhK --0000000000009d86cd060558a876 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable will do. On Thu, Sep 14, 2023 at 2:42=E2=80=AFPM Ludovic Court=C3=A8s = wrote: > Hi, > > Andy Tai skribis: > > > * gnu/packages/machine-learning.scm: (tensorflow-lite): > > Update to 2.13.0 > > [inputs]: Add gemmlowp > > [native-inputs]: Remove gemmlowp-src > > * > gnu/packages/patches/tensorflow-lite-disable-local-cmake-3rdparty-compone= nts.patch: > > New file > > Overall LGTM. Some comments=E2=80=A6 > > Could you add the patch to =E2=80=98gnu/local.mk=E2=80=99? > > > + (patches > > + (search-patches > > + ;; patch to disable local cmake build code for 3rdpart= y > > + ;; componentas > > + > "tensorflow-lite-disable-local-cmake-3rdparty-components.patch")))) > > Please add the comment at the top of the patch itself, as reported by > =E2=80=98guix lint=E2=80=99; also adjust indentation here as in the other= files. > > > + (string-append "-Dgemmlowp_ROOT=3D" #$(this-package-input > "gemmlowp")) > > + ) > > Please move paren to the previous line. > > > (invoke "tar" "--strip-components=3D1" > > "-xf" (assoc-ref inputs "fft2d-src"))) > > > > - (copy-recursively (assoc-ref inputs "gemmlowp-src") > > - "/tmp/gemmlowp/"))) > > + ;(copy-recursively (assoc-ref inputs "gemmlowp-src") > > + ; "/tmp/gemmlowp/") > > + > > + )) > > Leftover? You can remove these two lines. > > Could you send an updated patch? > > Thanks in advance, > Ludo=E2=80=99. > --=20 Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010 Year 2023 =E6=B0=91=E5=9C=8B112=E5=B9=B4 =E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B=E6=98=AF=E4=BF=A1=E4= =BB=B0=E8=88=87=E8=A6=BA=E6=82=9F =E8=87=AA=E5=8B=95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E=E5= =8B=95=E8=88=87=E6=8A=80=E8=83=BD --0000000000009d86cd060558a876 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
will do.

=
On Thu, Sep 14, 2023 at 2:42=E2=80=AF= PM Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
Hi,=

Andy Tai <atai@atai.o= rg> skribis:

> * gnu/packages/machine-learning.scm: (tensorflow-lite):
> Update to 2.13.0
> [inputs]: Add gemmlowp
> [native-inputs]: Remove gemmlowp-src
> * gnu/packages/patches/tensorflow-lite-disable-local-cmake-3rdparty-co= mponents.patch:
> New file

Overall LGTM.=C2=A0 Some comments=E2=80=A6

Could you add the patch to =E2=80=98gnu/local.mk=E2=80=99?

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(patches
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(search-patche= s
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; patch to d= isable local cmake build code for 3rdparty
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; componenta= s
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "tensorf= low-lite-disable-local-cmake-3rdparty-components.patch"))))

Please add the comment at the top of the patch itself, as reported by
=E2=80=98guix lint=E2=80=99; also adjust indentation here as in the other f= iles.

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(string-append "-Dgemmlowp_ROO= T=3D" #$(this-package-input "gemmlowp"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)

Please move paren to the previous line.

>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (invoke = "tar" "--strip-components=3D1"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 "-xf" (assoc-ref inputs "fft2d-src"= ;)))
>=C2=A0
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (copy-recursively (a= ssoc-ref inputs "gemmlowp-src")
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "/tmp/gemmlowp/"))) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;(copy-recursively (= assoc-ref inputs "gemmlowp-src")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "/tmp/gemmlowp/") > +
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ))

Leftover?=C2=A0 You can remove these two lines.

Could you send an updated patch?

Thanks in advance,
Ludo=E2=80=99.


--
=
Andy Tai, atai@atai.org, Skype: li= cheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2023 =E6=B0=91=E5=9C= =8B112=E5=B9=B4
=E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B= =E6=98=AF=E4=BF=A1=E4=BB=B0=E8=88=87=E8=A6=BA=E6=82=9F
=E8=87=AA=E5=8B= =95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E=E5=8B=95=E8=88=87= =E6=8A=80=E8=83=BD
--0000000000009d86cd060558a876--