From: Andy Tai <atai@atai.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 65835@debbugs.gnu.org
Subject: [bug#65835] [PATCH] gnu: tensorflow-lite: Update to 2.13.0
Date: Thu, 14 Sep 2023 14:49:28 -0700 [thread overview]
Message-ID: <CAJsg1E_xEm_eNvzGvHYQPG_pQyhpKwF1Dnj9+AN+NjsfgfvjNw@mail.gmail.com> (raw)
In-Reply-To: <87ttrw3005.fsf_-_@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1792 bytes --]
will do.
On Thu, Sep 14, 2023 at 2:42 PM Ludovic Courtès <ludo@gnu.org> wrote:
> Hi,
>
> Andy Tai <atai@atai.org> skribis:
>
> > * gnu/packages/machine-learning.scm: (tensorflow-lite):
> > Update to 2.13.0
> > [inputs]: Add gemmlowp
> > [native-inputs]: Remove gemmlowp-src
> > *
> gnu/packages/patches/tensorflow-lite-disable-local-cmake-3rdparty-components.patch:
> > New file
>
> Overall LGTM. Some comments…
>
> Could you add the patch to ‘gnu/local.mk’?
>
> > + (patches
> > + (search-patches
> > + ;; patch to disable local cmake build code for 3rdparty
> > + ;; componentas
> > +
> "tensorflow-lite-disable-local-cmake-3rdparty-components.patch"))))
>
> Please add the comment at the top of the patch itself, as reported by
> ‘guix lint’; also adjust indentation here as in the other files.
>
> > + (string-append "-Dgemmlowp_ROOT=" #$(this-package-input
> "gemmlowp"))
> > + )
>
> Please move paren to the previous line.
>
> > (invoke "tar" "--strip-components=1"
> > "-xf" (assoc-ref inputs "fft2d-src")))
> >
> > - (copy-recursively (assoc-ref inputs "gemmlowp-src")
> > - "/tmp/gemmlowp/")))
> > + ;(copy-recursively (assoc-ref inputs "gemmlowp-src")
> > + ; "/tmp/gemmlowp/")
> > +
> > + ))
>
> Leftover? You can remove these two lines.
>
> Could you send an updated patch?
>
> Thanks in advance,
> Ludo’.
>
--
Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat:
andytai1010
Year 2023 民國112年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能
[-- Attachment #2: Type: text/html, Size: 3045 bytes --]
next prev parent reply other threads:[~2023-09-14 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 7:44 [bug#65835] [PATCH] gnu: tensorflow-lite: Update to 2.13.0 Andy Tai
2023-09-10 7:23 ` [bug#65835] [PATCH v2] " Andy Tai
2023-09-14 21:42 ` [bug#65835] [PATCH] " Ludovic Courtès
2023-09-14 21:49 ` Andy Tai [this message]
2023-09-15 5:20 ` [bug#65835] [PATCH v2] " Andy Tai
2023-09-18 21:29 ` bug#65835: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJsg1E_xEm_eNvzGvHYQPG_pQyhpKwF1Dnj9+AN+NjsfgfvjNw@mail.gmail.com \
--to=atai@atai.org \
--cc=65835@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.