From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id +HxpCMQfQmYE6AAAe85BDQ:P1 (envelope-from ) for ; Mon, 13 May 2024 16:12:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id +HxpCMQfQmYE6AAAe85BDQ (envelope-from ) for ; Mon, 13 May 2024 16:12:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail-com.20230601.gappssmtp.com header.s=20230601 header.b=R3ncJsGh; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715609540; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lN3nsM1Ws0L7VNtW3TAGtEhWfnhJUahNnmmi0K/CKXc=; b=SJ6tolX0Z1xEw8X4XWQLbBS/OP3LBzdmESdF46ApDUazG6/aJgp1v0FJI6fxmDWVDU3QKr GsPJ9gFCo4WZLh/uu2aS63pUtR2zt8gk4XzK5TaK+YVO/5pUvM+iB2U7u+H0ZYAHxuT5eM VmoihKhr68gJpLVdQf380BGY6UP/3HJK3iGTmt+YvYPsJvlY5ZaMNeud6tOqDuZXXTZarH pjvbs7SBX0CsQQnYUY4oSJO2fIom8I0pwuABGs8VmHT3gL0vjM3ZUxnX9eQO7wBopoWYmL vi6tAJlrYeVFuugd8fMbJmehzkRit46xL4FivucEWyfKHdd0FmrZNa7Mrb3SFg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715609540; a=rsa-sha256; cv=none; b=S5SAmmoGnfCalm1ki6p9in+eM2xRQ2sEQyBN7ChUMylweb3vpJbTs5MJVSgFDTzBn2EgGC JFaD0qr6j51zLL0WhlAMSzYK4IHNPY9CBcYhrANDuIK6Y4VZ5WMK374okOcI5fDcrIKEXI 3VZDDBCoP+Rlb9LtM7M9JRdy3CJVT4B1PxC8kr0UcJC4VsO8hP5INoDyFzbgRAhl5Ix5ns C9LsFGzsON7BUC/IW222UAbqt5YW5PzZCzZ1M/tirP0qwZ5BHweRE5MYATcmTxMZi2vBYa Z8GNI8eYezSzid8RSCIbv3dFAN+tiZHLXpQNTELIjOABGtORgU5XZ8jzUSvAhA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail-com.20230601.gappssmtp.com header.s=20230601 header.b=R3ncJsGh; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 012D3BB8F for ; Mon, 13 May 2024 16:12:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6WPM-0006WX-0n; Mon, 13 May 2024 10:12:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6WPK-0006W7-7e for guix-patches@gnu.org; Mon, 13 May 2024 10:12:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6WPJ-0007Zf-VO for guix-patches@gnu.org; Mon, 13 May 2024 10:12:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s6WPJ-000272-Tl for guix-patches@gnu.org; Mon, 13 May 2024 10:12:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70563] QA review for 70563 Resent-From: Andy Tai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 May 2024 14:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70563 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 70563@debbugs.gnu.org, control@debbugs.gnu.org, Nicolas Graves Received: via spool by 70563-submit@debbugs.gnu.org id=B70563.17156095028113 (code B ref 70563); Mon, 13 May 2024 14:12:01 +0000 Received: (at 70563) by debbugs.gnu.org; 13 May 2024 14:11:42 +0000 Received: from localhost ([127.0.0.1]:32961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6WP0-00026i-Cm for submit@debbugs.gnu.org; Mon, 13 May 2024 10:11:42 -0400 Received: from mail-ua1-f45.google.com ([209.85.222.45]:42431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6WOx-00026X-6b; Mon, 13 May 2024 10:11:40 -0400 Received: by mail-ua1-f45.google.com with SMTP id a1e0cc1a2514c-7f919bc2e1cso2112865241.1; Mon, 13 May 2024 07:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail-com.20230601.gappssmtp.com; s=20230601; t=1715609432; x=1716214232; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lN3nsM1Ws0L7VNtW3TAGtEhWfnhJUahNnmmi0K/CKXc=; b=R3ncJsGhBLqEjEh/bcUae9rEGU14xcKnk5aLDgC1H/U8lF1BzaLhjRRK6GcvWv+G9Q e+F8IB7tGJKHNW5Fff4fN3aSM5SCiUzjgDP0/OpUMLqa90eFUckDb4wcicYZY+MyMA1d 1cquVXEWgdjpzrifSKgEbcKSGbQgFmg5fRy+C8hPnLJM67De536of3io75TE2M4hUndB McGLtWZiKAsqqLAn1mrVKXxITTn1APiGtc7a9WLOPclT28gazb7bmWFtOCBWNBJfl3tz KFVPMhxRuUpFCci41I1WUi0dK02vXzsRq+f4GQYe43X1Twy2dnJqBwLJVDNu9+OJgylc OBTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715609432; x=1716214232; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lN3nsM1Ws0L7VNtW3TAGtEhWfnhJUahNnmmi0K/CKXc=; b=iEGnqTKNQAgLyNtGSgvjDhDirmIEk08pYjLX6+Z6zkr6Tj/uB47LB5xBtZCIagV6KF yVhTON3O5hsi3fyrqn8QORDn+lHB3SZGp4NMI2/DHNfJATed9CBDrHmBzgApiRwOvKqi Jv0cjYI/+dCCFOIF16OIIdexuxFb62hOKUk/jjHuniYaBaW8Po0uJ86QDtIpYthfNIMU tWsZGNfWd1QqNswmSrYoWuGa/329mpzFOWDDFDVusSj3qfrTAz0ebO1tLReiBrYGoLbT r4wr2DnyMNIauufdLxJ7WuLQu1/oU5lOluQGiPXv3oySBMSAJicQ2mExNdorm1egeDVR MlkA== X-Forwarded-Encrypted: i=1; AJvYcCUUXusJNkaTSmFykN1sS1TVAI/6OHpvcgy6Q1HnxJWn43ctJv5y6mIaeOCMvj+CrXnmy9paGy6oq1DcQqL//poZm74LJwyAOKEk746tSYX/QhNOnZT1YQkyhaQPaDW0 X-Gm-Message-State: AOJu0YyQd2bxrEYiHcg2eEdxIzFygcIOovWYENaozLmqQmNOviXKj478 32Mb7oN0ZN8bfCx6UQOxy7b/qx0MdKsO7pOWeHuI+lQMVqvaPzwRBzpFUGfvHR83mAO7KgCuhva 3ABmpn0lvC1sreZJfdJXW7mR/xWU= X-Google-Smtp-Source: AGHT+IFCkxTOG/If+sK56J2LZZd2DlOKgbd4o54VfSNzrjcN16hZNqP4sGm5/++uQRfBWtpgGe2FafW8fsF/eKapu7E= X-Received: by 2002:a05:6102:5e9:b0:47c:d98:5863 with SMTP id ada2fe7eead31-47fab9aebf4mr9552201137.4.1715609431610; Mon, 13 May 2024 07:10:31 -0700 (PDT) MIME-Version: 1.0 References: <356e77d1fbad51a042ebb8eaae2804bb74a30c9b.1714036907.git.atai@atai.org> <877cfyci07.fsf@ngraves.fr> <875xvhc2le.fsf@gnu.org> In-Reply-To: <875xvhc2le.fsf@gnu.org> From: Andy Tai Date: Mon, 13 May 2024 07:09:54 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.37 X-Spam-Score: -2.37 X-Migadu-Queue-Id: 012D3BB8F X-Migadu-Scanner: mx11.migadu.com X-TUID: QNut/7gEhVpm OK I did not see that reply in email but I will send v2 patch addressing the comment On Mon, May 13, 2024 at 5:34=E2=80=AFAM Ludovic Court=C3=A8s = wrote: > > Hi Andy, > > Did you receive Nicolas=E2=80=99 message below? > > Nicolas Graves skribis: > > > user guix > > usertag 70563 + reviewed-looks-good > > thanks > > > > Guix QA review form submission: > > The description probably needs a little bit more precision. In particul= ar, it would be good to include the statement "PKCS#11 is the de-facto= standard to access cryptographic devices." or something like that. > > > > Otherwise LGTM. > > Note that despite being marked as =E2=80=9Creviewed-looks-good=E2=80=9D, = Nicolas makes > a suggestion that I think is worth addressing in a second version. > > Thanks, > Ludo=E2=80=99. --=20 Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andyta= i1010 Year 2024 =E6=B0=91=E5=9C=8B113=E5=B9=B4 =E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B=E6=98=AF=E4=BF=A1=E4= =BB=B0=E8=88=87=E8=A6=BA=E6=82=9F =E8=87=AA=E5=8B=95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E=E5= =8B=95=E8=88=87=E6=8A=80=E8=83=BD