From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT5r4-0007l3-Tl for guix-patches@gnu.org; Tue, 21 May 2019 10:35:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT5r3-0003dJ-Rj for guix-patches@gnu.org; Tue, 21 May 2019 10:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55188) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hT5r3-0003dB-OR for guix-patches@gnu.org; Tue, 21 May 2019 10:35:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hT5r3-0005Wi-KC for guix-patches@gnu.org; Tue, 21 May 2019 10:35:01 -0400 Subject: [bug#35788] [PATCH] gnu: libjit: add at 0.1.4 Resent-Message-ID: MIME-Version: 1.0 References: <20190518080649.21073-1-atai@atai.org> <87v9y3289k.fsf@gnu.org> In-Reply-To: <87v9y3289k.fsf@gnu.org> From: Andy Tai Date: Tue, 21 May 2019 07:34:34 -0700 Message-ID: Content-Type: multipart/alternative; boundary="0000000000001fe435058966c035" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35788@debbugs.gnu.org --0000000000001fe435058966c035 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Will do, thanks! On Tue, May 21, 2019 at 7:26 AM Ludovic Court=C3=A8s wrote: > Hi Andy, > > atai@atai.org skribis: > > > gnu/packages/libjit.scm | 72 +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 72 insertions(+) > > create mode 100644 gnu/packages/libjit.scm > > Could you submit an updated patch that adds libjit to assembly.scm > instead? Bonus point if you can provide a commit log that follows our > conventions. :-) > > Apart from these minor issues, the patch LGTM. > > Thanks in advance! > > Ludo=E2=80=99. > --=20 Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010 Year 2019 =E6=B0=91=E5=9C=8B108=E5=B9=B4 =E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B=E6=98=AF=E4=BF=A1=E4= =BB=B0=E8=88=87=E8=A6=BA=E6=82=9F =E8=87=AA=E5=8B=95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E=E5= =8B=95=E8=88=87=E6=8A=80=E8=83=BD --0000000000001fe435058966c035 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Will do, thanks!

On Tue, May 21, 2019 at 7:26= AM Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
Hi= Andy,

atai@atai.org skribi= s:

>=C2=A0 gnu/packages/libjit.scm | 72 +++++++++++++++++++++++++++++++++++= ++++++
>=C2=A0 1 file changed, 72 insertions(+)
>=C2=A0 create mode 100644 gnu/packages/libjit.scm

Could you submit an updated patch that adds libjit to assembly.scm
instead?=C2=A0 Bonus point if you can provide a commit log that follows our=
conventions.=C2=A0 :-)

Apart from these minor issues, the patch LGTM.

Thanks in advance!

Ludo=E2=80=99.


--
Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010=
Year 2019 =E6=B0=91=E5=9C=8B108=E5=B9=B4
=E8=87=AA=E5=8B=95=E7=9A=84= =E7=B2=BE=E7=A5=9E=E5=8A=9B=E6=98=AF=E4=BF=A1=E4=BB=B0=E8=88=87=E8=A6=BA=E6= =82=9F
=E8=87=AA=E5=8B=95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF= =E5=8B=9E=E5=8B=95=E8=88=87=E6=8A=80=E8=83=BD
=
--0000000000001fe435058966c035--